Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved OIIO subimages handling #920

Conversation

ReeceMulley
Copy link
Contributor

Changelog Description

Ayon's OIIOtool handling currently removes all subimages (all AOVs that aren't RGBA). This PR does the following:

  • takes out the argument that restricts to 1 subimage
  • modifies the colour conversion arguments to only occur on the first subimage (rgba).

The results of the OIIOtool will be unchanged, unless the input files have >1 subimages and the OIIOtool argument "-a" is added (should this be documented somewhere?). Then, extra channels will pass through the transcode, and can have reformats etc applied if desired.

Additional info

To have subimages identified, inputs must be a proper multipart EXR. In Nuke, this can be done by setting "interleave" to "channels" in the write node (very easy to define in the Ayon Nuke addon). Don't forget to set your channels to "all"!

Testing notes:

  1. Configure an Extract OIIO Transcode profile for a multipart exr (see additional info for more)
  2. Add "-a" into the profile's OIIOtool arguments
  3. Check that your extra AOVs have survived the transcode process

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels Sep 26, 2024
@kalisp kalisp requested a review from BigRoy September 26, 2024 09:30
@jakubjezek001 jakubjezek001 added the community Issues and PRs coming from the community members label Sep 26, 2024
Copy link
Contributor

@robin-ynput robin-ynput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your fix.

I can confirm this works great. I tested with the following inputs:

  • regular EXR
  • multipart EXR
  • JPEG

Colorspace is correctly applied to RGBA.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, Thanks!

@iLLiCiTiT iLLiCiTiT merged commit 1af24d8 into ynput:develop Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants