Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: setup playwright and first basic end to end tests #444

Conversation

Innders
Copy link
Member

@Innders Innders commented May 20, 2024

Description of changes

End to end testing is now implemented locally but NOT in the CI.

CI was taking too much effort for what it's worth. Local testing is fine.

Basic first tests:

  • Create and delete project
  • Create and delete user
  • Create and delete bundle

Technical details

First install all deps with yarn install

Test your PR locally using yarn test.

For a more visual test use yarn test-ui.

Create new tests with the help of yarn test-codegen.

Add new env variables for user auth (otherwise tests will fail)

NAME=*********
TEST_SERVER_URL=********
PASSWORD=*********

library link: https://playwright.dev/

@Innders Innders added the type: enhancement Improvement of existing functionality or minor addition label May 20, 2024
@Innders Innders self-assigned this May 20, 2024
@Innders Innders linked an issue May 20, 2024 that may be closed by this pull request
3 tasks
@Innders Innders requested a review from martastain May 20, 2024 13:52
@Innders Innders removed the request for review from martastain May 20, 2024 14:35
@Innders Innders added type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) and removed type: enhancement Improvement of existing functionality or minor addition labels Aug 8, 2024
@Innders Innders assigned flynput and unassigned Innders Aug 13, 2024
Copy link
Member Author

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests pass but I can't get authentication to pass. Maybe I have set it up wrong though.

image

Do you think that the tests could be separated even more now we have fixtures?

For example we have create and delete folders as one test. Does it make sense to now have two separate tests: create folder and delete folder. Or is that getting too separated?

@prodigel prodigel force-pushed the 432-Testing-Setup-Playwright-end-to-end-testing-and-write-first-tests branch from 553e0f6 to 808c2d1 Compare August 13, 2024 10:37
@flynput flynput merged commit a5aa069 into develop Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: Setup Playwright end-to-end testing and write first tests
2 participants