Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deno integration, deno linting and examples #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

load1n9
Copy link

@load1n9 load1n9 commented Apr 27, 2022

Description

deno example added to make the repo more friendly, updated deno linting and improved the deno readme file

Type of change

  • πŸ’” Breaking
  • πŸš€ Feature
  • πŸ› Fix
  • πŸ› οΈ Tooling
  • πŸ§ͺ Test
  • πŸ“¦ Dependency
  • πŸ“– Requires documentation update

@load1n9
Copy link
Author

load1n9 commented May 5, 2022

thoughts?

@yoav-lavi
Copy link
Owner

Hey @load1n9, it looks like most of this change is reformatting + adding the example that's already in the README.md, could you elaborate on why this is needed? Thanks

@load1n9
Copy link
Author

load1n9 commented May 6, 2022

Looks better for people who want to check the examples also you can run a file directly from a url in deno for them to test out the example without writing it. Refactor will make the code faster since the linter won't complain

@load1n9
Copy link
Author

load1n9 commented May 10, 2022

so how do you feel about this commit

@yoav-lavi
Copy link
Owner

yoav-lavi commented Jun 5, 2022

Hey @load1n9, I'm not sure it makes sense to reformat auto generated files. Regarding the example, that's already in the readme, is that folder used as some sort of convention? I understand the idea of using a URL, but is that common?

Regarding the formatting of the example - could you elaborate on why that was changed?

Thanks

@load1n9
Copy link
Author

load1n9 commented Jun 6, 2022

so basically having the examples in a folder allows people to test out whether your module works by running the examples directly with deno run -A --unstable https://deno.land/x/melody/examples/basic.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants