[Bug 574] Fixed: can not build out arm64 version for linux-android pl… #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atform Cause: cmake param "-DANDROID_ABI" should be "arm64-v8a", rather than "armeabi-v7a". Solution: 1. correct the wrong description in doc. 2. Add "-DANDROID_ABI" in the deps cmake files, otherwise these deps static libraries will all be default arm32. Fixed Version: 2021.1.19 Branch: master
yorkie
approved these changes
Jan 19, 2021
|
@db0218 May I ask you to push again to retrigger the build, it seems failed caused by networks. |
|
@algebrait @legendecas have a review? |
Should I close this one and start a new pull request ? |
|
You could just do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atform
Cause: cmake param "-DANDROID_ABI" should be "arm64-v8a", rather than "armeabi-v7a".
Solution: 1. correct the wrong description in doc. 2. Add "-DANDROID_ABI" in the deps cmake files, otherwise these deps static libraries will all be default arm32.
Fixed Version: 2021.1.19
Branch: master
Checklist
npm testpasses