Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump dompurify from 2.4.1 to 3.2.4 in /tgui (#22981)" #22985

Conversation

Oblisk234
Copy link
Member

Fixes #22984

Document the changes in your pull request

Reverts #22981

Why am I reverting before 48 hours have passed?

It broke fancychat (Not surprising after #22982)

Testing

Tgui-dev still works, fancychat works.
Hot updating

Changelog

🆑
bugfix: Fancychat no longer bluescreens.
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Feb 17, 2025
@MommaDragon
Copy link
Contributor

How did this crash Fancychat?

@Oblisk234
Copy link
Member Author

How did this crash Fancychat?

I don't know, but it works now. (Also I only noticed now this is outside of the 48 hour buffer for reverts)

@github-actions github-actions bot added Dependencies This PR relies on something else, or is supporting another PR tgui This PR affects TGUI labels Feb 17, 2025
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard stuff here

@ToasterBiome ToasterBiome merged commit 28041d2 into yogstation13:master Feb 17, 2025
15 checks passed
Yogbot-13 added a commit that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies This PR relies on something else, or is supporting another PR Fix This fixes an issue. Please link issues in fix PRs tgui This PR affects TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FancyChat crashes (reconnect or otherwise). That's about it.
4 participants