Fix constant error on firefox mobile from chrome.contextMenus (#1675)

* Fix constant error on firefox mobile from chrome.contextMenus * Put if check over whole block * Split out into separate method so it can early return
yomidevs · Dec 17, 2024 · f23c870 · f23c870
1 parent db9c07d
commit f23c870
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/ext/js/background/backend.js b/ext/js/background/backend.js
@@ -1330,7 +1330,20 @@ export class Backend {
             this._clipboardMonitor.stop();
         }
 
+        this._setupContextMenu(options);
+
+        void this._accessibilityController.update(this._getOptionsFull(false));
+
+        this._sendMessageAllTabsIgnoreResponse({action: 'applicationOptionsUpdated', params: {source}});
+    }
+
+    /**
+     * @param {import('settings').ProfileOptions} options
+     */
+    _setupContextMenu(options) {
         try {
+            if (!chrome.contextMenus) { return; }
+
             if (options.general.enableContextMenuScanSelected) {
                 chrome.contextMenus.create({
                     id: 'yomitan_lookup',
@@ -1348,10 +1361,6 @@ export class Backend {
         } catch (e) {
             log.error(e);
         }
-
-        void this._accessibilityController.update(this._getOptionsFull(false));
-
-        this._sendMessageAllTabsIgnoreResponse({action: 'applicationOptionsUpdated', params: {source}});
     }
 
     /**