Use first group schema type when there is only one group schema #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids hitting the fallback to using the property name which without further intervention results in missing types when compiling generated code.
Before
After
This change still would result in compilation errors for generated code where there was more than one possible schema for a group schema. Is there a proposed or correct way of handling this?
From what I can tell right now this will just generate the property type using a camel cased property name which seems a bit fragile - I am assuming the intention is this type be implemented manually but that seems error prone as there is the possibility of type collisions.