Skip to content

Add option to the caller to not always get the status online (in case the update is managed by the caller) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubeecube wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add option to the caller to not always get the status online (in case the update is managed by the caller) #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f286458
Add option to the caller to not always get the status online (in case…
rubeecube Dec 18, 2022
7c21027
Add option to the caller to not always get the status online (in case…
rubeecube Dec 18, 2022
ed0a1ee
Add option to the caller to not always get the status online (in case…
rubeecube Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions electrasmart/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def __init__(self, imei, token, ac_id, sid=None, use_single_sid=False):
self.sid = sid
self._status = None
self._model = None
self.last_update_status = None

def renew_sid(self):
try:
Expand All @@ -155,6 +156,7 @@ def renew_sid(self):

def update_status(self):
self._status = self._fetch_status()
self.last_update_status = datetime.now()

@property
def status(self):
Expand Down Expand Up @@ -193,8 +195,9 @@ def _parse_status_group(cls, v):
return json.loads(v)

@contextmanager
def _modify_oper_and_send_command(self):
self.update_status()
def _modify_oper_and_send_command(self, update_status=True):
if self._status is None or update_status:
self.update_status()
new_oper = self.status.raw["OPER"]["OPER"].copy()
# make any needed modifications inplace within the context
yield new_oper
Expand All @@ -213,8 +216,9 @@ def modify_oper(
shabat=None,
ac_sleep=None,
ifeel=None,
update_status=True,
):
with self._modify_oper_and_send_command() as oper:
with self._modify_oper_and_send_command(update_status=update_status) as oper:
if ac_mode is not None:
if self.model.on_off_flag:
if ac_mode == "STBY":
Expand Down