Update readdirp to address deprecation, inline noop2, and update minor versions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor version updates, and updating Standard to the latest major version. Updating Standard to latest does not introduce any formatting changes.
This would arguably save 420.5 MiB of npmjs.com bandwidth: the installed size of noop2 (3289 bytes) * 134076 weekly downloads (as of 2023-06-02).
The signature has changed. file.parentDir was also removed (in <paulmillr/readdirp@b2db33>), but it was simply defined as the parent of file.path, and can be replaced as such. This also addresses deprecation warnings coming from [email protected] -> snapdragon -> source-map-resolve. This is in fact the main motivation for this change. This might be considered a breaking change, as the minimum Node.js version of [email protected] is 8.10.0.
kisaragi-hiu
changed the title
kisaragi-hiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, copy-template-dir depends on [email protected], which depends on [email protected] → snapdragon → source-map-resolve (deprecated). This is unnecessary; this PR fixes it by updating readdirp to 3.6.0.
This might be considered a breaking change though, as readdirp 3.x raised the minimum Node version to 8.x.
This PR also inlines noop2 (
function () {}) - this arguably saves 420.5 MiB of unnecessary bandwidth per week (3289 bytes * 134076 weekly downloads ofcopy-template-diras of 2023-06-02).Additionally, I also updated the declared minor versions of other dependencies, as well as updating Standard to latest. This did not introduce any formatting changes.