Use rustix instead of calling libc directly.#21
Merged
sunfishcode merged 1 commit intoyoshuawuyts:masterfrom Jan 20, 2022
Merged
Use rustix instead of calling libc directly.#21sunfishcode merged 1 commit intoyoshuawuyts:masterfrom
sunfishcode merged 1 commit intoyoshuawuyts:masterfrom
Conversation
sunfishcode
force-pushed
the
sunfishcode/rustix
branch
2 times, most recently
from
9dacfd8 to
3bc0dcd
Compare
Use rustix instead of calling libc directly, which factors out several unsafe blocks and simplifies error handling. There is still one `unsafe` block needed, to dereference raw file descriptors passed in from the user, since the crate still uses `AsRawFd`. Once I/O safety is stablized in std, this crate can switch to using `AsFd`, which will eliminate the last `unsafe` block. This splits out just the API-compatible parts of yoshuawuyts#14. It does not include the changes to use the `AsFd` trait in the public API, so it's not an API-breaking change.
sunfishcode
force-pushed
the
sunfishcode/rustix
branch
from
3bc0dcd to
c72b806
Compare
yoshuawuyts
approved these changes
Jan 20, 2022
Owner
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
Looks good! Feel free to merge and/or publish this once you're comfortable with it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use rustix instead of calling libc directly, which factors out several
unsafe blocks and simplifies error handling.
There is still one
unsafeblock needed, to dereference raw filedescriptors passed in from the user, since the crate still uses
AsRawFd. Once I/O safety is stablized in std, this crate can switchto using
AsFd, which will eliminate the lastunsafeblock.This splits out just the API-compatible parts of #14. It does not include
the changes to use the
AsFdtrait in the public API, so it's not anAPI-breaking change.