Skip to content

bench: restore the forty baselines #945 recorded from a macOS-only run #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youknowone wants to merge 1 commit into from
Closed

bench: restore the forty baselines #945 recorded from a macOS-only run #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyre/bench/synth/arith_int_bool.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=10
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2213
guard_failures=2211
internal_compile_panics=0
loops_aborted=0
loops_compiled=8
loops_compiled=7
4 changes: 2 additions & 2 deletions pyre/bench/synth/arith_int_bool.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=10
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2213
guard_failures=2211
internal_compile_panics=0
loops_aborted=0
loops_compiled=8
loops_compiled=7

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid Linux-only values in the cross-platform stats gate

These values deliberately exclude the extra _fill_cache loop observed on macOS and Windows, but the default pyre/check.py invocation compares every recorded counter exactly and returns failure on any difference (_apply_snapshot_gate at pyre/check.py:1129-1148). Both pyre-check-macos and pyre-check-windows reuse that invocation as required CI jobs (.github/workflows/pyre-ci.yml:462-480), so those runners will observe their platform-specific loop/guard counts and fail these benchmarks. The import-side loop must be removed from the measurement, or the gate/baselines must represent platform-specific values, before committing Linux-only counts.

Useful? React with 👍 / 👎.

4 changes: 2 additions & 2 deletions pyre/bench/synth/ast_compile_roundtrip.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/ast_compile_roundtrip.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/gc_deque_backing_list.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=204
guard_failures=203
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/gc_deque_backing_list.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=204
guard_failures=203
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/imp_lock_rlock_semantics.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=3
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/imp_lock_rlock_semantics.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=3
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/import_from_name_path.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/import_from_name_path.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/inline_freevar_after_mayforce.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=473
guard_failures=471
internal_compile_panics=0
loops_aborted=0
loops_compiled=7
loops_compiled=6
4 changes: 2 additions & 2 deletions pyre/bench/synth/inline_freevar_after_mayforce.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=473
guard_failures=471
internal_compile_panics=0
loops_aborted=0
loops_compiled=7
loops_compiled=6
4 changes: 2 additions & 2 deletions pyre/bench/synth/module_getattr_descr_error.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/module_getattr_descr_error.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/module_getattr_surrogate_cls.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/module_getattr_surrogate_cls.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/operator_set_inplace_ops.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/operator_set_inplace_ops.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/pickle_ctor_args.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=2
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=437
guard_failures=436
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/pickle_ctor_args.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/print_stdout_redirect.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/print_stdout_redirect.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/pypy_dict_primitives_nonbinding.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/pypy_dict_primitives_nonbinding.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/seqiter_tuple_error_parity.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=203
guard_failures=202
internal_compile_panics=0
loops_aborted=0
loops_compiled=3
loops_compiled=2
4 changes: 2 additions & 2 deletions pyre/bench/synth/seqiter_tuple_error_parity.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=1
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=203
guard_failures=202
internal_compile_panics=0
loops_aborted=0
loops_compiled=3
loops_compiled=2
4 changes: 2 additions & 2 deletions pyre/bench/synth/simple_namespace_type.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/simple_namespace_type.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_pattern_methods.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=8
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1672
guard_failures=1670
internal_compile_panics=0
loops_aborted=0
loops_compiled=8
loops_compiled=7
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_pattern_methods.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=8
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1672
guard_failures=1670
internal_compile_panics=0
loops_aborted=0
loops_compiled=8
loops_compiled=7
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_wasm_min.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=5
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1163
guard_failures=1161
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_wasm_min.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=5
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1163
guard_failures=1161
internal_compile_panics=0
loops_aborted=0
loops_compiled=6
loops_compiled=5
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_wasm_min1.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=3
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=605
guard_failures=603
internal_compile_panics=0
loops_aborted=0
loops_compiled=5
loops_compiled=4
4 changes: 2 additions & 2 deletions pyre/bench/synth/sre_wasm_min1.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=3
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=605
guard_failures=603
internal_compile_panics=0
loops_aborted=0
loops_compiled=5
loops_compiled=4
4 changes: 2 additions & 2 deletions pyre/bench/synth/str_encode_text_codec.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/str_encode_text_codec.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=1
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/struct_pack_unpack.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/struct_pack_unpack.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=1
internal_compile_panics=0
loops_aborted=0
loops_compiled=2
loops_compiled=1
4 changes: 2 additions & 2 deletions pyre/bench/synth/type_dotted_name.cranelift.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
4 changes: 2 additions & 2 deletions pyre/bench/synth/type_dotted_name.dynasm.jitstats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ bridges_compiled=0
descr_set_absent=0
descr_set_ambiguous=0
descr_set_stale_absent=0
guard_failures=2
guard_failures=0
internal_compile_panics=0
loops_aborted=0
loops_compiled=1
loops_compiled=0
Loading