bench: record recursive_call_frame_relocation's windows dynasm guard_failures - #1049
bench: record recursive_call_frame_relocation's windows dynasm guard_failures#1049youknowone wants to merge 1 commit into
Conversation
…failures windows reports guard_failures=637 against a shared 638, on three consecutive runs at three different base shas (#1042 at 4fecf86, #1043 at a8677f4, main at 2f61280), with every other counter identical. check.py's overlay comment names the same value from two earlier runs. macos-latest and ubuntu-24.04 pass their dynasm legs against the shared file, so it keeps describing them. The single contrary reading is one run before that sequence, where windows reported 638 and `closure_per_call` reported 416. Both counters moved down by one at the same point and have held since; the move left `closure_per_call` agreeing with its shared file, which is why the overlay dropped in the previous commit is not needed and this one is. Assisted-by: Claude
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Codex parity reviewStatic analysis of this diff vs the local RPython/PyPy sources (commit 5b693d0). The diff against the review base changes only generated jit-stats baselines (1 file(s)); nothing to review. |
1 participant
main is red on windows dynasm with
recursive_call_frame_relocationguard_failures 638 -> 637. This records 637 as that host's value.4fecf865268(#1042)a8677f4a0a0(#1043)2f612802f1c(main, now)Three consecutive runs at three different base shas, every other counter
identical, and check.py's own overlay comment names 637 for windows from two
earlier runs. macos-latest and ubuntu-24.04 pass their dynasm legs against the
shared 638, so the shared file still describes them.
Both counters stepped down by one at the same point and have held since. That
move left
closure_per_callagreeing with its shared file — which is why#1043 dropped its overlay — and left this one disagreeing, which is why it
gets one.
🤖 Generated with Claude Code