Skip to content

gate brake both directions, and the 108 opcodes behind the codewriter catch-all #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Aug 8, 2026
Merged

gate brake both directions, and the 108 opcodes behind the codewriter catch-all #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00961a6
gate brake: scan the harness Python, and stop counting retirement rows
youknowone Aug 7, 2026
a24d123
codewriter: name the 108 opcodes the dispatch catch-all was hiding
youknowone Aug 7, 2026
cdf1d30
gate brake: fail on a live entry with no reader, and retire PYRE_FBW_…
youknowone Aug 7, 2026
ebdfb32
pyjitpl: name the snapshot frame-pc map after what it holds
youknowone Aug 7, 2026
21a6425
gate brake: a retired gate stays retired where the live sections ment…
youknowone Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions majit/majit-metainterp/src/pyjitpl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,10 @@ fn snapshot_map_from_trace_snapshots(
let mut size_map = Vec::new();
let mut vable_map = Vec::new();
let mut vref_map = Vec::new();
let mut pc_map = Vec::new();
// Not `pc_map`: that name belongs to the `-live-` marker table keyed by
// Python pc (`pc_map[py_pc]`, `pyre-jit/src/jit/codewriter.rs`). This is
// keyed by snapshot id and holds one `(jitcode_index, pc, py_pc)` per frame.
let mut frame_pcs_map = Vec::new();
// opencoder.py:603 _encode: trace snapshot recorder only emits Box
// (live deadframe slot) and Const (compile-time pool) payloads.
// TAGVIRTUAL belongs to resume numbering (resume.py:_number_boxes)
Expand Down Expand Up @@ -575,9 +578,9 @@ fn snapshot_map_from_trace_snapshots(
snapshot_insert(&mut size_map, id, frame_sizes);
snapshot_insert(&mut vable_map, id, vable_boxes);
snapshot_insert(&mut vref_map, id, vref_boxes);
snapshot_insert(&mut pc_map, id, frame_pcs);
snapshot_insert(&mut frame_pcs_map, id, frame_pcs);
}
(box_map, size_map, vable_map, vref_map, pc_map)
(box_map, size_map, vable_map, vref_map, frame_pcs_map)
}

struct PreparedBridgeTrace {
Expand Down Expand Up @@ -6025,7 +6028,7 @@ impl<M: Clone> MetaInterp<M> {
snapshot_frame_size_map,
mut snapshot_vable_map,
mut snapshot_vref_map,
snapshot_pc_map,
snapshot_frame_pcs,
) = snapshot_map_from_trace_snapshots(&trace_snapshots, &mut constants);
// history.py:220/261/307 — `Const{Int,Float,Ptr}.type` is an
// intrinsic attribute on the Box itself, so no raw-u32 type
Expand All @@ -6035,7 +6038,7 @@ impl<M: Clone> MetaInterp<M> {
unroll_opt.snapshot_frame_sizes = snapshot_frame_size_map.clone();
unroll_opt.snapshot_vable_boxes = snapshot_vable_map.clone();
unroll_opt.snapshot_vref_boxes = snapshot_vref_map.clone();
unroll_opt.snapshot_frame_pcs = snapshot_pc_map.clone();
unroll_opt.snapshot_frame_pcs = snapshot_frame_pcs.clone();
// The original snapshot maps are re-cloned into `simple_opt` on the
// InvalidLoop retry below, so they must stay rooted across the WHOLE
// unroll. Each phase's `replace_compile_snapshot_roots` overwrites the
Expand Down Expand Up @@ -6169,7 +6172,7 @@ impl<M: Clone> MetaInterp<M> {
simple_opt.snapshot_frame_sizes = snapshot_frame_size_map;
simple_opt.snapshot_vable_boxes = snapshot_vable_map;
simple_opt.snapshot_vref_boxes = snapshot_vref_map;
simple_opt.snapshot_frame_pcs = snapshot_pc_map;
simple_opt.snapshot_frame_pcs = snapshot_frame_pcs;
simple_opt.call_pure_results = call_pure_results.clone();
// Forward the recorder's operand pool — the retry path
// uses the same upstream `Rc<Box>` allocations from
Expand Down Expand Up @@ -8561,7 +8564,7 @@ impl<M: Clone> MetaInterp<M> {
snapshot_frame_size_map,
mut snapshot_vable_map,
mut snapshot_vref_map,
snapshot_pc_map,
snapshot_frame_pcs,
) = snapshot_map_from_trace_snapshots(&trace_snapshots, &mut constants);
self.compile_snapshot_refs = collect_snapshot_const_ptr_slots(&mut [
&mut snapshot_map,
Expand All @@ -8580,7 +8583,7 @@ impl<M: Clone> MetaInterp<M> {
optimizer.snapshot_frame_sizes = snapshot_frame_size_map;
optimizer.snapshot_vable_boxes = snapshot_vable_map;
optimizer.snapshot_vref_boxes = snapshot_vref_map;
optimizer.snapshot_frame_pcs = snapshot_pc_map;
optimizer.snapshot_frame_pcs = snapshot_frame_pcs;

// InvalidLoop during optimization should abort the trace, not crash
// the process. Matches compile_loop.
Expand Down Expand Up @@ -9003,7 +9006,7 @@ impl<M: Clone> MetaInterp<M> {
snapshot_frame_size_map,
mut snapshot_vable_map,
mut snapshot_vref_map,
snapshot_pc_map,
snapshot_frame_pcs,
) = snapshot_map_from_trace_snapshots(&trace_snapshots, &mut constants);
self.compile_snapshot_refs = collect_snapshot_const_ptr_slots(&mut [
&mut snapshot_map,
Expand All @@ -9014,7 +9017,7 @@ impl<M: Clone> MetaInterp<M> {
optimizer.snapshot_frame_sizes = snapshot_frame_size_map;
optimizer.snapshot_vable_boxes = snapshot_vable_map;
optimizer.snapshot_vref_boxes = snapshot_vref_map;
optimizer.snapshot_frame_pcs = snapshot_pc_map;
optimizer.snapshot_frame_pcs = snapshot_frame_pcs;

let optimize_start = Instant::now();
let optimize_result = optimizer.optimize_with_constants_and_inputs_oprc(
Expand Down
72 changes: 54 additions & 18 deletions pyre/gate-triage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ program point is not a safepoint, and the same bench is clean under the real
allocation-driven stress. Force collections through the GC's own stress hook,
never at a hand-picked instruction.

## §1c — Retired since the 2026-07-05 audit (10): reader already deleted by a closed epic
## §1c — Retired since the 2026-07-05 audit (11): reader already deleted by a closed epic

Book-keeping only: these OFF-paths were deleted in source by the cited epics
after the 2026-07-05 audit; this pass removes their stale registry rows. The
Expand All @@ -255,6 +255,7 @@ after the 2026-07-05 audit; this pass removes their stale registry rows. The
| PYRE_P2_FS_COMPILE | PR#374 (`9a97c47f6e9`) | stale §5 deferred entry removed |
| PYRE_P2_AUTHORITATIVE | reader gone; attribution #374 per re-audit | stale §5 deferred entry removed |
| PYRE_SAME_GREENKEY | PR#390 (`802b79ff8db`); follow-up `111bdb4eeb8` dropped the gate | stale §1b deferred mention and §5 list entry removed |
| PYRE_FBW_REC_UNROLL | PR#374 (`9a97c47f6e9`) deleted `fbw_unroll_bound()` | stale §5 config-switch entry removed 2026-08-08. The successor knob `PYRE_FBW_REC_UNROLL_DEPTH` was never listed here and its reader `fbw_max_rec_unroll_depth()` is gone too (PR#887, `e5546b2ed36`) — both names read from nothing |

## §1d — Parity verdicts for the default-OFF `PYRE_FBW_*` seams (2026-07-25)

Expand Down Expand Up @@ -770,14 +771,17 @@ residual level under the walked frame and an inlined level under that, so the
force has to reach two frames up. Per-frame vable binding, outer-locals
materialization, and the `jit.virtual_ref` emit are therefore validatable now.

## §2 — Not gates (11): Rust identifiers, not env vars
## §2 — Not gates (12): Rust identifiers, not env vars

The audit regex matched non-env identifiers. These are real code; **do not
delete, do not count as gates.**

- `PYRE_STR_DESCR`, `PYRE_STR_BYTE_LEN_DESCR`, `PYRE_UNICODE_DESCR`,
`PYRE_UNICODE_LEN_DESCR` — field-descriptor `const`s (`pyre-jit-trace/src/pyre_cpu.rs`)
- `PYRE_CLASS_DESCRIPTOR` — macro-built identifier `W_{}_PYRE_CLASS_DESCRIPTOR` (`pyre-macros`)
- `PYRE_CLASS_DESCRIPTORS` — the whole-program `linkme` distributed slice the
macro registers into (`pyre-object/src/lltype.rs`); the only `PYRE_*` name that
appears outside Rust and Python source, and it is not an env var
- `PYRE_PARAM_NAMES`, `PYRE_PARAM_REQUIRED` — macro `const __PYRE_PARAM_*` (`pyre-macros`)
- `PYRE_JIT_GRAPH_MODULES` — compile-time `const &[&str]` module manifest (`generated.rs`)
- `PYRE_REF_OPAQUE` — `OpaqueType::gc("PYRE_REF_OPAQUE")` type label (`annotator/builtin.rs`)
Expand Down Expand Up @@ -875,12 +879,12 @@ Kept as-is; listed for completeness.
the mirror is seeded and then read by nobody. Definition of done before
re-evaluating: make the maintenance sites read the ACTIVE callee jitcode
metadata (what the gate doc already asks for), then land a consumer.
- **Config / value / master switches (~18)** — tuning, paths, modes; keep:
`PYRE_FBW_REC_UNROLL`, `PYRE_WALKER_STORE_SUBSCR_FNADDR`,
- **Config / value / master switches (~17)** — tuning, paths, modes; keep:
`PYRE_WALKER_STORE_SUBSCR_FNADDR`,
`PYRE_MIR_FRONTEND_LLBC`, `PYRE_WASM_ENGINE`, `_FUEL`, `_MODULE`, `_NO_CACHE`,
`PYRE_GC_INTERP`, `PYRE_JIT`, `PYRE_NO_JIT`, `PYRE_STDLIB`,
`PYRE_CHECK_PYPY3`, `PYRE_CHECK_PYTHON3`, `PYRE_SANDBOX_NO_SECCOMP`,
`PYRE_SHARED_BUILD`, `PYRE_SYNTH_PYPY`, `_PYRE`, `_PYTHON`.
`PYRE_SHARED_BUILD`, `PYRE_SYNTH_PYPY`, `PYRE_SYNTH_PYRE`, `PYRE_SYNTH_PYTHON`.
- **Test harness (1)**: `PYRE_MIR_STRESS_LLBC`.

## §6 — The 66 gates the audits never listed (2026-08-07)
Expand All @@ -893,22 +897,54 @@ with no entry here fails `cargo test`. The counts to quote, distinguished:

| count | value |
|---|---|
| distinct names read from the environment | **105** |
| (file, name) read pairs | 128 |
| distinct names read from the environment | **111** |
| — of those, read from Rust | 105 |
| — read only from the harness Python | 6 |
| (file, name) read pairs | 137 |
| **live gates that were absent from this file** | **66** |
| names here with no read site left (retire) | 51 |
| names still listed live with no read site left (retire) | 0 |

```sh
git ls-files '*.rs' | xargs rg --no-filename -o \
'(env::var[_a-z]*|host_os::var|getenv)\(b?"(PYRE_[A-Z0-9_]+)"' -r '$2' | sort -u
{ git ls-files '*.rs'; git ls-files 'pyre/**/*.py' 'scripts/*.py'; } \
| xargs rg --no-filename -o \
'(env::var[_a-z]*|host_os::var|getenv|environ\.get)\(b?"(PYRE_[A-Z0-9_]+)"' \
-r '$2' | sort -u
```

`--no-filename` is what makes this count gates: without it rg prefixes each hit
and `sort -u` counts (file, name) pairs instead. The two seam forms matter for
the same reason — `host_os::var` and `host_seam::ops::getenv` (a *byte* string)
are how `importing.rs` reads `PYRE_STDLIB`, and a `std::env` search alone would
miss a sandbox- or wasm-only gate entirely. Neither seam form adds a name here;
both are `PYRE_STDLIB`, already read through `env::var` in `pyre-wasm-runner`.
and `sort -u` counts (file, name) pairs instead. Each read form is here because
something was hiding behind it:

- `host_os::var` and `host_seam::ops::getenv` (a **byte** string) are how
`importing.rs` reads `PYRE_STDLIB`. Neither adds a name — that gate is also
read through `env::var` in `pyre-wasm-runner` — but a sandbox- or wasm-only
gate would have had no such cover.
- `environ.get` and `getenv` are the harness. Six gates are read from
`check.py`, `check_synthetic.py`, the `extra_tests` runners and
`scripts/llbc_extract.py` and from no Rust file at all, so every `*.rs`
census — including this section's first draft — missed all six.

Only unambiguous reads count. The harness also *writes* into a child's
environment (`env[…] = …`, `env.pop(…)`), and writing a gate for a child is not
owning it: the child's read is what this file is about. A subscript cannot be
told from a read without parsing, and naming a fixture variable here would enter
it in the census as a documented gate — which is why the example above has no
name in it.

**Spell every name in full at least once.** This file abbreviates runs of related
gates (`PYRE_WASM_ENGINE`, `_FUEL`, `_MODULE`), and the brake matches whole
tokens, so a name appearing *only* in that shorthand reads as undocumented.
`PYRE_SYNTH_PYRE` and `PYRE_SYNTH_PYTHON` were written `_PYRE`, `_PYTHON`, and
were the only two the widened census reported missing — they had been documented
all along. The shorthand is fine beside a full spelling; it is not fine alone.

**A retirement row documents nothing, wherever it sits.** §1/§1b/§1c/§2/§3 are
history sections and no name in them counts. But §1d's heading reads *Parity
verdicts*, so that section reads live while its table marks
`PYRE_FBW_VABLE_SCALAR_CA` **RETIRED** — a mixed section, which section
granularity cannot express. So any row that says "retired" is skipped too, and
re-introducing a reader for a retired gate fails the brake rather than passing on
the strength of its own obituary.

Polarity below follows this file's rule, with one correction it needed: an
`is_none()` whose value *is* the enable flag means default **ON**, but an
Expand Down Expand Up @@ -962,11 +998,11 @@ already-ON criterion. They are listed so they cannot be missed again.

| bucket | count |
|---|---|
| retired (§1 + §1b + §1c + §1d parity pass) | 5 + 4 + 10 + 1 |
| not gates (identifiers) | 11 |
| retired (§1 + §1b + §1c + §1d parity pass) | 5 + 4 + 11 + 1 |
| not gates (identifiers) | 12 |
| dead (no read site) | 10 |
| live default-ON, kept until epic closes | 9 (+ `PYRE_GC_INTERP`, wasm32-only) |
| diagnostics (OFF) | ~34 |
| default-OFF experiments (all keep — adoption targets) | 3 |
| config / value / master | ~18 |
| config / value / master | ~17 |
| test harness | 1 |
Loading
Loading