Fix workspace Clippy warnings without crate-wide allows - #1165
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 242 files, which is 142 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (242)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Codex parity reviewStatic analysis of this diff vs the local RPython/PyPy sources (commit d227d75). Files in the reviewed diff1. Regressions to PyPy parity introduced by this patchNone. 2. Other mismatches introduced by this patchNone. 3. Pre-existing mismatches (already present before this patch)
4. Structural adaptations
|
youknowone
force-pushed
the
ec-wiring
branch
2 times, most recently
from
August 12, 2026 07:04
bfaedba to
7087ad2
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7087ad2f7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Overflow fallthrough: return x29 as jf_ptr. | ||
| ; mov x0, x29 | ||
| ; ldp x19, x20, [sp, #16] | ||
| ; ldp x21, x22, [sp, #32] |
There was a problem hiding this comment.
When an AArch64 compiled trace takes the stack-overflow early-return path, this instruction loads arbitrary scratch contents from [sp, #32] into the caller's callee-saved x21/x22 registers. The prologue saves only x19/x20, matching this backend's CALLEE_SAVED_REGISTERS, so there is no corresponding x21/x22 value at that offset; returning after this load can silently corrupt caller state. Remove this restore rather than diverging from the normal footer/upstream register set.
AGENTS.md reference: AGENTS.md:L231-L233
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 291f69f8b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let nlocals = code.varnames.len() + pyre_interpreter::pyframe::ncells(code); | ||
| let call = decode_op_at(&pjc.jitcode.code, call_jit_pc)?; | ||
| let result_bank = call.argcodes.chars().last()?; | ||
| let result_slot = (result_bank != 'v' && depth != 0).then_some(nlocals + depth - 1); |
There was a problem hiding this comment.
When this root-stack capture handles a void JitCode call with kept caller operands, argcodes does not end in 'v'; void instructions omit the > result marker entirely (for example, inline_call_r_v/dR). This condition therefore mistakes the final input-bank code for a result and replaces the caller's real top stack value with PY_NULL, corrupting the frame resumed by the blackhole. Detect a result from the >i/>r/>f suffix instead of comparing the final character with 'v'.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a89aba046c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let ptr = buf.as_mut_ptr() as usize; | ||
|
|
||
| let frame = backend.execute_token(&token, &[Value::Ref(GcRef(ptr)), Value::Float(3.14159)]); | ||
| let frame = backend.execute_token(&token, &[Value::Ref(GcRef(ptr)), Value::Float(3.25)]); |
There was a problem hiding this comment.
Using 3.25 weakens this f64 round-trip test because the value is represented exactly in both f64 and f32. If both RawStore and RawLoadF were accidentally lowered as 32-bit operations, the test could now pass despite losing double precision, whereas the previous 3.14159 input would expose that regression under the 1e-10 tolerance. Use a non-exact value that does not trigger the approximate-constant lint, or std::f64::consts::PI, so this continues to verify f64 precision.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation