posix id setters, __fspath__ binding, sendfile vectors and exec environments; a -c argument's common indentation

majit/majit-metainterp/src/warmstate.rs

@@ -707,7 +707,7 @@ impl WarmEnterState {
         self.counter.tick(bucket, self.increment_threshold)
     }
 
-    pub fn maybe_compile(&mut self, cell_key: u64) -> HotResult {
+    pub fn maybe_compile_decision(&mut self, cell_key: u64) -> HotResult {
         let mut cleanup_dead_token_cell = false;
         if let Some(cell) = self.cell_by_key(cell_key) {
             let has_procedure_token = cell.get_procedure_token().is_some();
@@ -723,7 +723,7 @@ impl WarmEnterState {
             }
             if self.should_start_dont_trace_here_trace(cell_key, flags, has_seen_a_procedure_token)
             {
-                return self.start_tracing_cell(cell_key);
+                return HotResult::StartTracing;
             }
             // A JC_DONT_TRACE_HERE cell declines here, except when it once saw a
             // procedure token that has since been invalidated — that dead entry
@@ -752,7 +752,25 @@ impl WarmEnterState {
             return HotResult::NotHot;
         }
 
-        self.start_tracing_cell(cell_key)
+        HotResult::StartTracing
+    }
+
+    /// [`Self::maybe_compile_decision`] followed by the mark that
+    /// `warmstate.py:441` makes once the decision is taken:
+    /// `cell.flags |= JC_TRACING | JC_TRACING_OCCURRED`, immediately before
+    /// the `try:` that runs the trace.
+    ///
+    /// Callers that go straight from the answer into `setup_tracing` want
+    /// this form. A caller that instead delegates to a tracing entry point
+    /// which makes its own decision — `MetaInterp::bound_reached` reaches the
+    /// same cell through [`Self::force_start_tracing_for_key`] — must take the
+    /// decision alone, or that second call reads the mark this one left and
+    /// answers `AlreadyTracing` for the trace it was asked to start.
+    pub fn maybe_compile(&mut self, cell_key: u64) -> HotResult {
+        match self.maybe_compile_decision(cell_key) {
+            HotResult::StartTracing => self.start_tracing_cell(cell_key),
+            other => other,
+        }
     }
 
     /// warmstate.py:446-511 `WarmEnterState.maybe_compile_and_run` —

pyre/bench/synth/for_iter_direct_store_double.cranelift.jitstats

@@ -3,12 +3,13 @@ descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
 fbw_blackhole_adopted_multi_frame=0
-fbw_blackhole_adopted_single_frame=4
+fbw_blackhole_adopted_single_frame=8
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
 guard_failures=0
 internal_compile_panics=0
-loops_aborted=4
+loops_aborted=8
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/for_iter_direct_store_double.dynasm.jitstats

@@ -3,12 +3,13 @@ descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
 fbw_blackhole_adopted_multi_frame=0
-fbw_blackhole_adopted_single_frame=4
+fbw_blackhole_adopted_single_frame=8
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
 guard_failures=0
 internal_compile_panics=0
-loops_aborted=4
+loops_aborted=8
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/for_iter_direct_store_double.wasm.jitstats

@@ -3,12 +3,13 @@ descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
 fbw_blackhole_adopted_multi_frame=0
-fbw_blackhole_adopted_single_frame=2
+fbw_blackhole_adopted_single_frame=6
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
 guard_failures=0
 internal_compile_panics=0
-loops_aborted=2
+loops_aborted=6
 loops_compiled=0
+retraces_compiled=0

pyre/bench/synth/getframe_force_cancel_journal.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=0
 internal_compile_panics=0
 loops_aborted=5
 loops_compiled=0
+retraces_compiled=0

pyre/bench/synth/getframe_inline_subwalk_multiframe.cranelift.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
-fbw_blackhole_adopted_single_frame=9
+fbw_blackhole_adopted_multi_frame=0
+fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=8948
 internal_compile_panics=0
-loops_aborted=15
-loops_compiled=0
+loops_aborted=1
+loops_compiled=2
+retraces_compiled=0

pyre/bench/synth/getframe_inline_subwalk_multiframe.dynasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
-fbw_blackhole_adopted_single_frame=9
+fbw_blackhole_adopted_multi_frame=0
+fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=8948
 internal_compile_panics=0
-loops_aborted=15
-loops_compiled=0
+loops_aborted=1
+loops_compiled=2
+retraces_compiled=0

pyre/bench/synth/getframe_inline_subwalk_multiframe.py

@@ -1,61 +1,45 @@
-# No `max-pypy-ratio`: this fixture compiles no loop -- its jitstats record
-# `loops_compiled=0` -- so a pypy ratio compares two interpreters' startup
-# rather than any generated code, and reads whatever the host's process
-# spawn cost happens to be that run. The jitstats baselines gate it.
-# Coverage for the multi-frame blackhole build path: an INLINED callee that
-# forces an outer frame through `sys._getframe(2)`.
+# Frame-identity regression for two `_getframe` operations executed from an
+# inlined `leaf` MIFrame.  The depth-zero lookup must return `leaf`'s own red
+# frame, and its `f_locals` proxy must retain that frame so reading `"x"`
+# observes the live callee local.  The positive-depth lookup must start from the
+# same callee frame and reach `main`, where `"base"` is stored.
 #
-# The walker executes a residual call concretely, so that level gets a real
-# frame from the interpreter's own call sequence; an inline push did not run
-# that sequence, so its level had none. A force fired from the inlined body
-# therefore built a frame chain that mixed the two, rooted at the intermediate
-# residual frame rather than the walked frame, and
-# `try_adopt_multi_frame_blackhole`'s chain-root identity gate declined it. What
-# that decline wanted was the `jit.virtual_ref` emit at the inline push
-# (`executioncontext.py:89`); `walker_ec_enter` / `walker_ec_leave` landed it, so
-# the chain-root gate no longer fires here, and with every level resumable from
-# the concrete frame it owns, the chain is adopted rather than replayed. This fixture pins the
-# result across that adopt.
+# Collapsing either lookup onto the portal frame changes the namespace: the
+# first read loses `x`, while the second lands on the module frame and loses
+# `base`.  Residualizing the depth-zero lookup instead forces the published
+# callee during tracing and prevents this loop from compiling.  The specialized
+# path therefore records the callee frame and creates its `FrameLocalsProxy`
+# without forcing the outer standard virtualizable; positive-depth lookup stays
+# on the established virtual-reference walk until its per-level lowering is
+# available.
 #
-# The build wants an escape whose forced frame is the one the inline sub-walk
-# PUBLISHED, so the chain has a residual level under the walked frame and an
-# inlined level under that. `sys._getframe(0).f_locals` in `leaf` is that
-# escape: the depth-0 call names `leaf`'s own frame, the arm declines inside a
-# sub-walk, and the getset forces the published frame.
+# A real PyPy run compiles one loop with no bridges, forcings, virtualizable
+# forcings, or aborts.  Pyre must print the same value, compile one loop, and
+# report no escape abort or frame-blackhole adoption for this fixture.
 #
-# The `sys._getframe(2)` read below is the OUTPUT guard and is not what reaches
-# the build -- `getframe` forces only the frame it returns, and two levels up is
-# `main`'s, i.e. the portal, which escapes on the ordinary portal path. Without
-# the depth-0 line the file still answers correctly and stops building a
-# multi-frame image at all (measured: `fbw_blackhole_adopted_multi_frame` 5 ->
-# 0). In the historical gate-enabled sweep with `PYRE_FBW_DEBUG_ABORT=1`, 0 of
-# 310 fixtures reached `BUILT multi-frame`.
-#
-# The multi-frame image is built unconditionally when the latch conditions hold,
-# so this is both an output guard and build-path coverage: 5 builds, 5 adopts,
-# and zero declines of any kind (`PYRE_FBW_DEBUG_ABORT=1` prints every tally;
-# the other 5 escapes in the run have `inline_subwalk=false` and take the
-# single-frame arm, which adopts too).
-#
-# What the decline used to hold back, measured by lifting it before the
-# execution-context push landed: the resumed chain shifted every
-# `sys._getframe(n)` up exactly one level, so the read below landed on the
-# module frame and raised `KeyError: 'base'`. Variants of this shape that cannot
-# raise returned a wrong number instead, silently -- `f_locals.get("base", -1)`
-# scored -1 for 7, `len(f_locals)` scored the module globals' 12 for this
-# frame's 3, `len(f_code.co_name)` scored `<module>`'s 8 for a 9-character
-# caller name. That is the failure mode this fixture still guards: every outcome
-# arm was wrong, not only the one carrying a resume coordinate.
-#
-# Carries only a generous `# pyre-check: max-pypy-ratio=` tripwire (top of
-# file), not a tight perf gate: this guards an output, and the forcing read
-# makes it a poor perf subject, so the ratio is a gross-regression guard.
+# The positive-depth clause has a measured cost, and the recorded counters
+# encode it rather than endorse it.  `leaf`'s `_getframe(2)` reaches `main`'s
+# frame, which is the virtualizable of `main`'s compiled loop, and materializes
+# it.  `mid(i)` stays a residual `CallMayForce` in that loop, so the
+# `GuardNotForced` behind it fails on every machine-code entry: `MAJIT_STATS=1`
+# reports `mc_entered` equal to `guard_failures`, with `back_edge_polls=0` and
+# `bridges_compiled=0`, so the compiled loop leaves for the blackhole before it
+# ever crosses its back edge.  The attribution is a one-run check -- a `leaf`
+# holding only the depth-zero read records `guard_failures=1`, one holding only
+# the `_getframe(2)` read reproduces the full count.  The recorded
+# `guard_failures` is therefore a known shortfall of the positive-depth walk,
+# not a number to preserve; it is expected to fall once that walk gets its
+# per-level lowering.  `loops_compiled` counts two traces here: `main`'s loop,
+# and a linear `Finish` trace for the inlined `mid` -> `leaf` chain, whose own
+# four `GuardNotForced`s never fail.  The wasm baseline records
+# `guard_failures=1` instead because that backend always materializes the
+# virtualizable, which makes `GuardNotForced` a no-op there.
 import sys
 
 
 def leaf(x):
-    sys._getframe(0).f_locals  # noqa: B018 — the read itself is the force under test
-    return sys._getframe(2).f_locals["base"] + x
+    own_x = sys._getframe(0).f_locals["x"]
+    return sys._getframe(2).f_locals["base"] + own_x
 
 
 def mid(x):

pyre/bench/synth/getframe_inline_subwalk_multiframe.wasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
-fbw_blackhole_adopted_single_frame=9
+fbw_blackhole_adopted_multi_frame=0
+fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=15
-loops_compiled=0
+loops_aborted=1
+loops_compiled=2
+retraces_compiled=0

pyre/bench/synth/getframe_inlined_callee_own_frame.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=1
 internal_compile_panics=0
 loops_aborted=1
 loops_compiled=2
+retraces_compiled=0

pyre/bench/synth/getframe_root_loop_force_blackhole_crn_declined.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=0
 internal_compile_panics=0
 loops_aborted=5
 loops_compiled=0
+retraces_compiled=0

pyre/bench/synth/getframe_root_loop_force_blackhole_crn_nonidempotent_declined.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=0
 internal_compile_panics=0
 loops_aborted=5
 loops_compiled=0
+retraces_compiled=0

pyre/bench/synth/getframe_root_loop_force_while_merge_declined.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=0
 internal_compile_panics=0
 loops_aborted=5
 loops_compiled=0
+retraces_compiled=0

pyre/bench/synth/getframe_stored_fback_walk.dynasm.jitstats

@@ -12,3 +12,4 @@ guard_failures=0
 internal_compile_panics=0
 loops_aborted=5
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_caller_locals_across_subwalk.cranelift.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_caller_locals_across_subwalk.dynasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_caller_locals_across_subwalk.wasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_captured_frame_outlives_call.cranelift.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_captured_frame_outlives_call.dynasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0

pyre/bench/synth/getframe_while_captured_frame_outlives_call.wasm.jitstats

@@ -2,13 +2,14 @@ bridges_compiled=0
 descr_set_absent=0
 descr_set_ambiguous=0
 descr_set_stale_absent=0
-fbw_blackhole_adopted_multi_frame=5
+fbw_blackhole_adopted_multi_frame=0
 fbw_blackhole_adopted_single_frame=0
 fbw_rolled_back_with_effects=0
 fbw_store_journal_rollback_failed=0
 field_pos_attached_misplaced=0
 field_pos_spec_misplaced=0
-guard_failures=0
+guard_failures=1
 internal_compile_panics=0
-loops_aborted=5
+loops_aborted=0
 loops_compiled=1
+retraces_compiled=0