bench: fix the two wasm jitstats diffs #1960 landed with - #1971
Conversation
…frontend's wasm overlay #1960 landed with two wasm snapshot diffs on its ubuntu check.py job. pickle_terminal_raise_resume on wasm reads loops_compiled=24, loops_aborted=4, guard_failures=139 on ubuntu-24.04 and darwin-arm64, which is the native baseline, so the wasm overlay is deleted. gc_pypy_frontend's guard_failures counts GuardClass failures over the gc.get_rpy_roots() list, which the fixture header documents as a per-runner root-population figure under a band of 8. After #1960 the wasm run reads 375 on ubuntu-24.04 and 377 on darwin-arm64 (331 before); loops_compiled=2 and bridges_compiled=1 are unchanged. The overlay takes the ubuntu reading. Assisted-by: Claude Opus 5.5
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughTwo synthesized benchmark JIT statistics files changed. One ChangesSynthesized benchmark statistics
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: 🟡 Moderate · up to The required Linux wasm benchmark job now compares this fixture against native JIT stats after its wasm snapshot was deleted. The last wasm snapshot differs on unbanded counters, including one classified as a regression if those readings persist; verify the current wasm baseline before merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the figures bright Comment |
🤖 Codex parity reviewStatic analysis of this diff vs the local RPython/PyPy sources (commit 7f0aa78). The diff against the review base changes only generated jit-stats baselines (2 file(s)); nothing to review. |
Merging this PR will not alter performance
Comparing Footnotes
|
#1960 merged with two wasm snapshot diffs on its ubuntu
pyre/check.py dynasmjob (which also runs the wasm backend); main has carried them since.pickle_terminal_raise_resume: wasm now readsloops_compiled=24,loops_aborted=4,guard_failures=139on ubuntu-24.04 and darwin-arm64, identical to the native baseline, so the wasm overlay is deleted.gc_pypy_frontend:guard_failurescounts GuardClass failures overgc.get_rpy_roots(), a per-runner root-population figure under the fixture'sjitstats-band=guard_failures=8. The wasm run reads 375 (ubuntu) / 377 (darwin) after wasm: dead frame, guard cells and residual-call signatures on their upstream owners #1960, 331 before;loops_compiled/bridges_compiledare unchanged. The overlay takes the ubuntu reading.More wasm backend orthodoxy work (propagate-exception exit reader,
CALL_RELEASE_GILerrno, stack check, label targets on the token) will be stacked on this branch.🤖 Generated with Claude Code
Summary by CodeRabbit