extra_tests: drop snippets covered by the CPython suite - #1986
Merged
Merged
Conversation
Remove the ungated RustPython snippet corpus. Language, builtin, and stdlib behaviour already lives in lib-python/3/test/. Keep the gated pyre-authored snippets and testutils.py. Assisted-by: Grok
Assisted-by: Grok
Remove 22 gate=1 snippets whose observables are already asserted in lib-python/3/test_ (test_builtin, test_bytes, test_descr, test_set, test_enum, test_scope, test_class, pickletester). Assisted-by: Grok
|
Important Review skippedToo many files! This PR contains 277 files, which is 177 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (277)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b18e94409
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+3
to
+4
| Pure-Python snippet tests for CPython-compatibility gaps that the vendored | ||
| CPython suite (`lib-python/3/test/`) does not pin, and that do not belong to a |
There was a problem hiding this comment.
This removal leaves several previously gated observables untested in CI: the only CPython-suite workflow invocation uses the normal PASS-only selection, and pyre/cpython_tests/run.py explicitly deselects non-PASS modules. The modules cited by the deleted snippets are currently non-PASS in pyre/cpython_tests/baseline.json (test.test_builtin is FAIL, test.test_bytes and test.test_class are IMPORTERROR, test.test_descr is FAIL, and test.test_scope is CRASH), so removing the corresponding 17 gate=1 snippets means their builtin/bytes/class/closure behavior is no longer exercised by either gate. Keep those snippets (or add equivalent tests to a CI-executed PASS suite) until their owning CPython modules are actually gated.
Useful? React with 👍 / 👎.
🤖 Codex parity reviewStatic analysis of this diff vs the local RPython/PyPy sources (commit 5b18e94). Files in the reviewed diffCodex did not produce a report (exit 1). Last log lines: |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop
pyre/extra_tests/snippetsthat duplicate the vendored CPython suite (lib-python/3/test/).lib-python/3/test/).gate=1snippets whose observables are already asserted intest_builtin,test_bytes,test_descr,test_set,test_enum,test_scope,test_class, andpickletester.testutils.py.parity_tests/is unchanged; those scripts already declare a CPython-suite gap.Self-review
Assisted-byto commit messages to the commits AI wrote.