UI v0.21.2 모달제목타이포적용 - #39
Hidden character warning
Conversation
.yds-modal-title에 타이포그래피가 빠져 있어 title이 브라우저 기본 h2로 렌더되던 문제 수정. ConfirmDialog 제목과 동일하게 s1 폰트 토큰(size/ line-height/weight/family)과 흰색을 적용. 스토리도 컴포넌트 자체 스타일이 드러나도록 수동 span 래핑을 제거하고 문자열 title로 정리. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request bumps the package version to 0.21.2 and refactors the modal title styling. The modal title in the stories has been simplified from a JSX element to a plain string, and the corresponding typography styles (font-size, line-height, font-weight, font-family, and color) have been moved directly into the .yds-modal-title CSS class. The review feedback suggests two improvements: using a common font-weight token instead of a potentially non-existent size-specific weight token, and replacing the primitive --color-white token with a semantic text color token to support future theme extensions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| margin: 0; | ||
| font-size: var(--font-size-yds-s1); | ||
| line-height: var(--line-height-yds-s1); | ||
| font-weight: var(--font-weight-yds-s1); |
There was a problem hiding this comment.
| line-height: var(--line-height-yds-s1); | ||
| font-weight: var(--font-weight-yds-s1); | ||
| font-family: var(--font-yds-wanted); | ||
| color: var(--color-white); |
개요
0.20.1에서 추가한 모달 고정 헤더의 제목(
title)에 타이포그래피 토큰이 누락돼 있던 버그를 수정합니다.문제
.yds-modal-title에margin: 0만 있어title이 브라우저 기본h2로 렌더됨title을<span className="text-yds-s1 text-white">로 감싸 소비자 쪽에서 폰트를 입혔던 탓에 문제가 가려져 있었음 →title: '문자열'처럼 쓰면 스타일 없이 나옴수정
.yds-modal-title에 ConfirmDialog 제목과 동일한 s1 타이포 토큰 적용font-size/line-height/font-weight→--*-yds-s1font-family→--font-yds-wanted,color→--color-whitespan래핑 제거 → 문자열title로 정리해 컴포넌트 자체 스타일이 드러나게 함커밋 구성
🤖 Generated with Claude Code