Bulk Delete for History Items #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b (mirror HistoryPage)
- Fixed critical issue: Changed handleBulkDelete to use api.deleteHistoryBulk() - Previously used Promise.all with multiple api.deleteHistory() calls - Now properly uses single bulk delete API call with transaction support - Applied fix to both HistoryPage.tsx and HistoryTab.tsx - Created comprehensive E2E verification document - Verified all implementation layers (database, controller, RPC, API, UI) - TypeScript compilation verified - Ready for live testing
- Create test_database.py with comprehensive bulk delete tests - Test multiple record deletion in transaction - Test audio file cleanup for all deleted entries - Test empty list edge case handling - Test invalid ID handling - Test transaction rollback on errors - Test mixed audio/no-audio entries QA Fix Session: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bulk selection and deletion functionality to the History page and History tab, allowing users to select multiple transcription entries and delete them all at once. This improves user efficiency when managing large numbers of historical transcriptions.