Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #366

Closed
wants to merge 1 commit into from
Closed

Update README.rst #366

wants to merge 1 commit into from

Conversation

cgestes
Copy link
Contributor

@cgestes cgestes commented Sep 12, 2022

some updates to the README.rst to make it easier to onboard new users.

Some of my collaborators decided to clone the content of the manifest by hand, to avoid using tsrc (because they couldn't make it work) :/

@dmerejkowsky
Copy link
Collaborator

OK, but using pip outside a virtualenv is dangerous and may break things down the road :(

What exactly did go wrong with pipx ?

@dmerejkowsky
Copy link
Collaborator

I've merged the rest of the changes in the README, which are fine :)

@cgestes
Copy link
Contributor Author

cgestes commented Sep 21, 2022

it seems that a lot of people never heard of pipx, and just install pip. (which is also my case).
So having to install a tool to grab sources is annoying, having to grab two is even more..

I believe almost everyone default to use pip cause it's the standard tool. (especially on windows and mac)

@gdubicki
Copy link
Member

I think that pipx should remain the recommended way to install tsrc but we can add a line saying that you can also use plain pip, if you know what you are doing. What do you think, @cgestes?

@Lecrapouille
Copy link
Contributor

@gdubicki @cgestes Remind me my initial remarks #332 I was aware that python has virtual stuff to fix versioning conflict but I never used pipx and pip worked fine :)

@gdubicki
Copy link
Member

gdubicki commented Nov 20, 2022

There's also #343 - haven't seen this issue before today as it was not linked to this PR...

gdubicki added a commit to gdubicki/tsrc that referenced this pull request Nov 20, 2022
gdubicki added a commit to gdubicki/tsrc that referenced this pull request Nov 20, 2022
gdubicki added a commit to gdubicki/tsrc that referenced this pull request Nov 20, 2022
@gdubicki
Copy link
Member

gdubicki commented Nov 20, 2022

Your remaining suggestions about pipx will de facto be applied when #376 will get merged, so I take the liberty to close this PR now.

@gdubicki gdubicki closed this Nov 20, 2022
@gdubicki gdubicki mentioned this pull request Nov 20, 2022
@gdubicki
Copy link
Member

Thank you for your contribution @cgestes! :)

dmerejkowsky pushed a commit that referenced this pull request Dec 16, 2023
As suggested by Lecrapouille and cgestes
in #332, #366, #343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants