Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SMOS40 registers for 3.5.5 firmware #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomtaylor
Copy link

Exported all the registers from an SMOS40 running 3.5.5 firmware, and updated the JSON. Hopefully there's no surprises in there.

modbus_addresses_all_20250126-06765423023074-1.csv

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (e3d5fc0) to head (c75024c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files          14       14           
  Lines        1358     1358           
=======================================
  Hits          953      953           
  Misses        405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04
Copy link
Owner

yozik04 commented Jan 26, 2025

I usually modify existing lines that were updated in the new CSV, append new lines and keep lines missing from new file.
Deduplication might be required before conversion to json, but the tool prints errors if something is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants