Enhance/previous or next page #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes a bug where the previous/next buttons are still clickable even though they have been disabled via CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
This PR fixes it by making
#previous_or_next_pagereturn a nestedspaninstead of a nesteda. This is the recommended implementation in the Bootstrap 2, Bootstrap 3 and Bootstrap 4 documentations.Referenced from issue #29
Reintroduces support for Bootstrap 2
Would you be okay with having support for some legacy codebases out there? This is entirely up to you- and I'll be happy to remove this commit if you don't feel comfortable having it in your codebase. Just for your reference, I currently need Bootstrap 2 support for your gem.
Modified the page_number method to also return a span instead of a li. This will also ensure that it is not clickable even though it is disabled.
Let me know what your thoughts are about the concept or the code- will be happy to make any changes :) & thank you for maintaining this gem! 💪