Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-visible views and OnScreenSwitchListener #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RedHatter
Copy link

When horizontalpager had a child view that had visibility set to View.GONE it would correctly not call onLayout for it, but would incorrectly still take it into account in other calculations. This behavior would cause an empty black screen to appear at the end. My patch fixes this by not counting children with View.GONE set.

My patch also adds onScreenSelected to OnScreenSwitchListener to notify user about a new screen but before the animation.

@ysamlan
Copy link
Owner

ysamlan commented Jul 16, 2014

Thanks for the contribution, but this library is obsoleted by Google's release of their own ViewPager library as part of the Android Compatibility Package (since compatlib rev 3). I would recommend using that for any new development; this library is not maintained any longer, and I can't see any advantage to using this over Google's official blessed implementation.

@RedHatter
Copy link
Author

Google's ViewPager is several times more complex to use. So if a simple pager is needed for a small part the project works much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants