This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Open
Conversation
Owner
Author
|
There still is the following warning, but it looks like this is unavoidable ( |
Owner
Author
|
@mpapis is it possible to avoid the warning message? If not, then I'm ok. |
|
the warning is displayed when you have |
libexec/prax-start
Outdated
There was a problem hiding this comment.
if you are about to merge it better move the set -e after sourcing RVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rvmbranch and this pull request will eventually make Prax correctly handle RVM.The first commit removes any specific Ruby from
$PATHwhich allows Prax to run Racker from a clean shell which should let RVM do it's job of choosing the correct ruby and gemset for the project.This looks like to be enough with a simple Rack application (setting .ruby-version and restarting the instance actually selects the correct Ruby version):