Do not fetch grafana version when it is already specified via config #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ysde would I be able to get your review on this one? |
|
Thanks @pmorelli92 for the fix. I encountered the same bug. |
|
Bump on this. Encountered the same bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned before in #184 Amazon Managed Grafana does not support the
api/healthendpoint. The mentioned PR did a fix to not do the health check but the same call was still being used to fetch the grafana version. This was making the backup to fail for any Amazon Grafana users.In the codebase the
GRAFANA_VERSIONwas already being parsed in different places but then the API call took precedence even when it was defined. So in this PR I basically made a conditional to not fetch the version with API calls if it is defined.