Fix empty body issue when GET fails #282
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GET fails, the body is empty, so an attempt to convert the body to JSON raises an exception.
The solution here is to return a valid empty JSON body to the caller, that might expect a valid JSON.
This problem has been tackled in other places (but not in
set_user_role
norset_grafana_put
) in different ways.get_grafana_version
does not attempt anything if status is not 200log_response
catchesValueError
exceptions and then logsr.text
(fine, because print can handleNone
)set_grafana_post
catchesValueError
and then returnsr.text
.I did not go for the same approach as
set_grafana_post
because I believe the caller should always receive a valid JSON.