Feature/gh 118 aws virtual network #624
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return nil | ||
| } | ||
|
|
||
| func (g *awsGenerator) generateSubnet(ctx context.Context, nodeParams nodeParams, instanceName string, outputs map[string]string) error { |
There was a problem hiding this comment.
Method awsGenerator.generateSubnet has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
| return nil | ||
| } | ||
|
|
||
| func (g *awsGenerator) generateSubnet(ctx context.Context, nodeParams nodeParams, instanceName string, outputs map[string]string) error { |
There was a problem hiding this comment.
Method awsGenerator.generateSubnet has 65 lines of code (exceeds 50 allowed). Consider refactoring.
| "github.com/ystia/yorc/v4/prov/terraform/commons" | ||
| ) | ||
|
|
||
| func (g *awsGenerator) generateVPC(ctx context.Context, nodeParams nodeParams, instanceName string, outputs map[string]string) error { |
There was a problem hiding this comment.
Method awsGenerator.generateVPC has 52 lines of code (exceeds 50 allowed). Consider refactoring.
| return nil | ||
| } | ||
|
|
||
| func (g *awsGenerator) generateSubnet(ctx context.Context, nodeParams nodeParams, instanceName string, outputs map[string]string) error { |
There was a problem hiding this comment.
Method awsGenerator.generateSubnet has 54 lines of code (exceeds 50 allowed). Consider refactoring.
HildericSB
requested review from
stefbenoist,
laurentganne,
loicalbertin,
adidanes and
Loic-R
|
Can't open topology.zip |
VPC can't be attached to compute instance, only subnet can. |
|
Ok but we should allow to attach an existing subnet from an existing VPC to a compute ? |
Ok got it ! |
prov/terraform/aws/resources.go
Outdated
| Attachment map[string]string `json:"attachment,omitempty"` | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
comment on exported type SecurityRule should be of the form "SecurityRule ..." (with optional leading article)
prov/terraform/aws/resources.go
Outdated
| CidrBlock []string `json:"cidr_blocks,omitempty"` | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
comment on exported type SecurityGroups should be of the form "SecurityGroups ..." (with optional leading article)
prov/terraform/aws/resources.go
Outdated
| Name string `json:"name,omitempty"` | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
comment on exported type RouteTable should be of the form "RouteTable ..." (with optional leading article)
| DependsOn []string `json:"depends_on,omitempty"` | ||
| } | ||
|
|
||
| type DefaultRouteTable struct { |
There was a problem hiding this comment.
exported type DefaultRouteTable should have comment or be unexported
prov/terraform/aws/resources.go
Outdated
| DependsOn []string `json:"depends_on,omitempty"` | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
comment on exported type InternetGateway should be of the form "InternetGateway ..." (with optional leading article)
prov/terraform/aws/aws_instance.go
Outdated
| i := 0 | ||
| for _, networkReq := range networkRequirements { | ||
| networkInterface := &NetworkInterface{} | ||
| // TODO : Check if subnet and security group are defined in relationship |
|
Kudos, SonarCloud Quality Gate passed!
|
| name = strings.Replace(strings.ToLower(name), "_", "-", -1) | ||
|
|
||
| // First interface will be considered the network interface of the Compute Instance | ||
| if i == 0 { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| name = strings.Replace(strings.ToLower(name), "_", "-", -1) | ||
|
|
||
| // First interface will be considered the network interface of the Compute Instance | ||
| if i == 0 { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit c0641d8 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
SonarCloud Quality Gate failed.
|
Pull Request description
Description of the change
Now possible to attach a subnet to AWS instance.
What I did
How I did it
How to verify it
-Try deploying a ACompute linked with a ANetwork.
Applicable Issues
#Fixes #118