Upgrade to Couchbase 4 (and other build changes) #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #123 ↗︎
Details:
Review all test suite changes for PR #117 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 40.95% 41.11% +0.15%
==========================================
Files 20 21 +1
Lines 1487 1491 +4
Branches 94 94
==========================================
+ Hits 609 613 +4
+ Misses 828 827 -1
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably the CB SDK v4 moves to couchbase-cxx-client rather than libcouchbase and makes some changes to how it gets loaded, which seem to break when the server is bundled (seemingly they assume that their js file will always be run from their package folder under
node_modules), so work around this by externalising it in esbuild and installing it in the built Docker image. Similar story with argon2 (though for different reasons - esbuild for some reason always bundles the amd64 version even on arm64).