Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minirmd to run on .fasta files #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thernn88
Copy link

@Thernn88 Thernn88 commented Feb 13, 2023

Patches a segfault that occurs when sequences are longer than the first sequence in a file. This allows minirmd to run on .fasta files.

Minimal performance hit to check all string lengths.

Elapsed time for max_strlen: 0.331280s

This is the time it took to find the longest sequence for 13,835,165 sequences in a fasta file.

Patches a segfault that occurs when sequences are longer than the first sequence in a file.

Minimal performance hit to check all string lengths.

Elapsed time for max_strlen: 0.331280s

This was to find the longest sequence  for 13,835,165 sequences
@Thernn88
Copy link
Author

Thernn88 commented Feb 13, 2023

Part of a series of commits which will patch minirmd to properly function on input with unequal sequence lengths.

With the above patch it is functional, but will miss a small amount of duplicates. No improper culls were observed.

optional -l arg allows the user to specify where they would like the duplicates removed to go.

Additionally, if the input/output is a fasta file sequence headers now start with a >.

If the input/output is a fastq file sequence headers still begin with a @
@Thernn88
Copy link
Author

Thernn88 commented Feb 14, 2023

Duplicates removed are clustered by the parent sequence and header.

Parent sequence headers end with a . for easy identification. Subsequent headers and sequences are duplicates of said parent and header pair. This remains true until the next header ending with a . is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant