Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow combine multiple changes into one changeset #4

Open
LaoshuBaby opened this issue Mar 13, 2022 · 1 comment
Open

Allow combine multiple changes into one changeset #4

LaoshuBaby opened this issue Mar 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request priority/SHOULD 75%

Comments

@LaoshuBaby
Copy link
Contributor

Hello! yuiseki-san!

I'm very sorry for bring new trouble to you. Here are a few suggestions that I came up with after experiencing it today.

This issue is about the logic of uploading to the OSM database after making changes. For many countries or regions with non-exhaustive addresses, users may edit several addresses in batches for a short time. If you create changeset instantly after each edit, will it create too many small changesets?

So in my opinion, perhaps you should consider adding a buffer to allow users to merge multiple changes into one changeset.

But this may not be what you want, so please disregard this piece of suggestion.

images

Besides, even you don't change anything, it still will create a new changeset!

No matter what changes are made, the changeset comment will be "Update address", can it be appended with other combinations based on the building name or ID to make it easier to find? And will this comment be considered to be adapted to the locale used by the user (perhaps this may need to wait until the user interface i18n is fully worked on? (If you want, I‘m willing to be translator of the simplified and traditional Chinese variants)

For example: 更新地址 w12345678, w87654321 or 更新地址 w12345678(北京大厦), w87654321

images

changeset's tag, attribution generally refers to the source of the data, you can refer to the use case on taginfo. And the tag seems to be gradually replaced by the source tag, you have written the host.

images

Additional.

I haven't tested it on mobile devices, so I can't say if it would be convenient to see addresses on the street instantly (I've used OsmAnd before, but it's still bloated at times)

@yuiseki
Copy link
Owner

yuiseki commented Mar 19, 2022

@LaoshuBaby Sorry for late reply. Thank you for pointing out quite a few details!

I am a newbie when it comes to OpenStreetMap API, so all the information is very helpful.

I thought this issue could be split into multiple issues, so I opened several issues as refer this issue.

  1. So in my opinion, perhaps you should consider adding a buffer to allow users to merge multiple changes into one changeset.

  2. Besides, even you don't change anything, it still will create a new changeset!

  3. No matter what changes are made, the changeset comment will be "Update address"

  4. And the tag seems to be gradually replaced by the source tag, you have written the host.

  5. Make it easy to use on mobile devices

I have split this list as 2. to #6 , 3. to #7 and 4. to #8

I have fixed 4. in this commit, thanks to inform me.
7dd2632

Regarding 1., I would also consider combining multiple changes into one changeset, I'll do whatever I can.

@yuiseki yuiseki self-assigned this Mar 19, 2022
@LaoshuBaby LaoshuBaby changed the title Creation logic of changeset Allow combine multiple changes into one changeset Mar 19, 2022
@yuiseki yuiseki added enhancement New feature or request priority/SHOULD 75% labels Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/SHOULD 75%
Projects
None yet
Development

No branches or pull requests

2 participants