Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable submit button if form has not any change #6

Open
yuiseki opened this issue Mar 19, 2022 · 1 comment
Open

Disable submit button if form has not any change #6

yuiseki opened this issue Mar 19, 2022 · 1 comment
Assignees
Labels
bug Something isn't working priority/SHOULD 75%

Comments

@yuiseki
Copy link
Owner

yuiseki commented Mar 19, 2022

Split from: #4

We should only be able to be sent when data changes are made.

@LaoshuBaby
Copy link
Contributor

LaoshuBaby commented Mar 21, 2022

Sorry, this issue should be reopen, its more serious

Because I've succeed in uploading a zero modify changeset by fake input

I fill the source, then input something in any field, then delete it. But the program still think is uploadable.

You can see this reproduce video:

2022-03-21.16-39-35.mp4

Changeset: https://www.openstreetmap.org/changeset/118724702


To avoid this kind of problem, you'd better diff the data before upload, not only disable the button.

@yuiseki yuiseki reopened this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/SHOULD 75%
Projects
None yet
Development

No branches or pull requests

2 participants