Perf: defer is not free

yunginnanet · Jun 17, 2024 · 00e908a · 00e908a
1 parent 31a2739
commit 00e908a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/heffalump/heffalump.go b/heffalump/heffalump.go
@@ -48,14 +48,16 @@ func (h *Heffalump) WriteHell(bw *bufio.Writer) (int64, error) {
 	}()
 
 	buf := h.pool.Get().([]byte)
-	defer h.pool.Put(buf)
 
 	if _, err = bw.WriteString("<html>\n<body>\n"); err != nil {
+		h.pool.Put(buf)
 		return n, err
 	}
 	if n, err = io.CopyBuffer(bw, h.mm, buf); err != nil {
+		h.pool.Put(buf)
 		return n, nil
 	}
 
+	h.pool.Put(buf)
 	return n, nil
 }