Add logger.console_time_format option #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunginnanet
requested changes
Jan 18, 2024
I personally enjoy watching the pretty logs in my terminal, but I don't like AM/PM. This allows users to set whatever they want in the console, while keeping the old '03:04PM' format as a default. This change does not affect the logs written to file.
ginger51011
force-pushed
the
feat/add-console-time-format
branch
from
f031538
to
ad88677
Compare
|
Good point, fixed now, sorry for messy PR :) |
yunginnanet
approved these changes
Jan 18, 2024
yunginnanet
added a commit
that referenced
this pull request
Jun 26, 2024
Add logger.console_time_format option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally enjoy watching the pretty logs from hell in my terminal, but I don't like AM/PM.
This allows users to set whatever they want in the console, while keeping the old
03:04PMformat as a default.This change does not affect the logs written to file.
Right now I don't do any validation on the format, but setting the value to something like
666just uses that for all the timestamps, which I guess is nice for screenshots.