Bugfix: don't detach tag when tags is empty (#105)

this bug is introduced by #95

Signed-off-by: Duan Jiong <[email protected]>

pkg/executor/tags.go

@@ -7,6 +7,10 @@ import (
 )
 
 func AttachTagsToResources(tagapi *service.TagService, tags []string, resourceIDs []string, resourceType string) error {
+	if len(tags) <= 0 {
+		return nil
+	}
+
 	input := &service.AttachTagsInput{}
 	for _, tag := range tags {
 		for _, resourceID := range resourceIDs {
@@ -29,6 +33,10 @@ func AttachTagsToResources(tagapi *service.TagService, tags []string, resourceID
 }
 
 func DetachTagsFromResources(tagapi *service.TagService, tags []string, resourceIDs []string, resourceType string) error {
+	if len(tags) <= 0 {
+		return nil
+	}
+
 	input := &service.DetachTagsInput{}
 	for _, tag := range tags {
 		for _, resourceID := range resourceIDs {

pkg/loadbalance/annotations.go

@@ -46,6 +46,7 @@ const (
 	ServiceAnnotationLoadBalancerEipSource = "service.beta.kubernetes.io/qingcloud-load-balancer-eip-source"
 
 	//ReuseExistingLB  use existing loadbalancer on the cloud
+	//We can't change any properties.
 	ReuseExistingLB Policy = "reuse-lb"
 	// Shared represent the EIP can be shared with other service which has no port conflict
 	Shared Policy = "reuse"

pkg/loadbalance/loadbalancer_listener.go

@@ -113,6 +113,8 @@ func (l *Listener) CreateQingCloudListenerWithBackends() error {
 	l.initBackends()
 	err = l.backendList.CreateBackends()
 	if err != nil {
+		//It is possible that the hostname has been modified, and when adding the backend, you can't find the host
+		//by the hostname. we should adding annotation "node.beta.kubernetes.io/instance-id" to the node
 		klog.Errorf("Failed to create backends of listener %s", l.Name)
 		return err
 	}