Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ deps: bump pyo3 to 0.23 and add free-threading test #388

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 15, 2024

动机

升级 PyO3 到 0.23 并尝试支持 free-threading

free-threading 不支持 abi3 feature,需要移除(本 PR 未修改,但本地验证过),但这会对编译流水线有影响(要发好多包),还得看看有没有什么比较好的解决方案

解决方案

类型

  • ✨ feat: 添加新功能
  • 🐛 fix: 修复 bug
  • 📝 docs: 对文档进行修改
  • ♻️ refactor: 代码重构(既不是新增功能,也不是修改 bug 的代码变动)
  • ⚡ perf: 提高性能的代码修改
  • 🧑‍💻 dx: 优化开发体验
  • 🔨 workflow: 工作流变动
  • 🏷️ types: 类型声明修改
  • 🚧 wip: 工作正在进行中
  • ✅ test: 测试用例添加及修改
  • 🔨 build: 影响构建系统或外部依赖关系的更改
  • 👷 ci: 更改 CI 配置文件和脚本
  • ❓ chore: 其它不涉及源码以及测试的修改
  • ⬆️ deps: 依赖项修改
  • 🔖 release: 发布新版本

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #388 will not alter performance

Comparing bump-pyo3-and-add-free-threading-ut (eb78854) with main (2590962)

Summary

✅ 30 untouched benchmarks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • tests/test_biliass/test_corpus: Language not supported
Comments skipped due to low confidence (1)

packages/biliass/rust/src/lib.rs:22

  • Ensure that the behavior with GIL disabled is covered by tests.
#[pymodule(gil_used = false)]
@SigureMo SigureMo merged commit 13be789 into main Nov 15, 2024
30 checks passed
@SigureMo SigureMo deleted the bump-pyo3-and-add-free-threading-ut branch November 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant