Skip to content

Conversation

sgaist
Copy link

@sgaist sgaist commented Oct 4, 2022

While the service itself does not require them, there are situations that may.

The example at hand is connecting to a JupyterHub instance that uses a custom certificate authority.

To the best of my knowledge there are two solutions:

  • Create a custom image that contains all the required certificates
  • Use an init container that will update the system's certs storage with additional certificates

This patch implements the latter as it avoids creating new images just for that purpose and the additional certificates can be easily changed using a central storage.

An example for it is using the service to access a JupyterHub instance that is
behind a PKI based certificate.
Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think the indentation needed some tweaks, and that the schema needs to be updated. See https://github.com/yuvipanda/jupyterhub-ssh/blob/main/helm-chart/jupyterhub-ssh/schema.yaml.

@sgaist
Copy link
Author

sgaist commented Oct 4, 2022

You're welcome !

I added the new fields to the schema but there are several others that are not documented. Since they are unrelated to this change, should they be added in a separate MR ?

@sgaist sgaist requested a review from consideRatio November 3, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants