Remove unused attr

close #7
yuzumone · Feb 8, 2017 · a22faf0 · a22faf0
1 parent 84820fc
commit a22faf0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ Add this to your app `build.gradle` file.
 ```gradle
 dependencies {
     ...
-    compile 'com.github.yuzumone:StateButton:0.1.1'
+    compile 'com.github.yuzumone:StateButton:0.1.2'
 }
 ```
 
@@ -70,7 +70,7 @@ To set text of the button you use the setTrueText or setFalseText functionality
 ```xml
 app:trueText="True"
 or
-app:trueTextRes="@string/true_string"
+app:trueText="@string/true_string"
 ```
 
 ### Java

diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
@@ -16,7 +16,7 @@
         android:id="@+id/button"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        app:trueTextRes="@string/true_string"
-        app:falseTextRes="@string/false_string"
+        app:trueText="@string/true_string"
+        app:falseText="@string/false_string"
         />
 </RelativeLayout>
diff --git a/statebutton/build.gradle b/statebutton/build.gradle
@@ -10,8 +10,8 @@ android {
     defaultConfig {
         minSdkVersion 16
         targetSdkVersion 25
-        versionCode 1
-        versionName "0.1.1"
+        versionCode 3
+        versionName "0.1.2"
 
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
 

diff --git a/statebutton/src/main/java/net/yuzumone/statebutton/StateButton.java b/statebutton/src/main/java/net/yuzumone/statebutton/StateButton.java
@@ -50,15 +50,7 @@ private void init(Context context, AttributeSet attrs, int defStyle) {
         Boolean state = array.getBoolean(R.styleable.StateButton_state, false);
 
         trueText = array.getString(R.styleable.StateButton_trueText);
-        int trueStringRes = array.getResourceId(R.styleable.StateButton_trueTextRes, 0);
-        if (trueStringRes != 0) {
-            trueText = context.getString(trueStringRes);
-        }
         falseText = array.getString(R.styleable.StateButton_falseText);
-        int falseStringRes = array.getResourceId(R.styleable.StateButton_falseTextRes, 0);
-        if (falseStringRes != 0) {
-            falseText = context.getString(falseStringRes);
-        }
 
         setState(state);
         array.recycle();

diff --git a/statebutton/src/main/res/values/attr.xml b/statebutton/src/main/res/values/attr.xml
@@ -3,8 +3,6 @@
     <declare-styleable name="StateButton">
         <attr name="state" format="boolean"/>
         <attr name="trueText" format="string"/>
-        <attr name="trueTextRes" format="integer"/>
         <attr name="falseText" format="string"/>
-        <attr name="falseTextRes" format="integer"/>
     </declare-styleable>
 </resources>