Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated fit_predict & fit_predict_score #617

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

onixlas
Copy link
Contributor

@onixlas onixlas commented Dec 23, 2024

Remove deprecated fit_predict & fit_predict_score from BaseDetector class and all the corresponding tests. These methods were marked as deprecated in version 0.6.9 and were expected to be removed in version 0.8.0.

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@onixlas onixlas changed the base branch from master to development December 23, 2024 18:47
@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12478149249

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 95.113%

Files with Coverage Reduction New Missed Lines %
pyod/models/rgraph.py 1 65.38%
pyod/models/cblof.py 2 85.11%
pyod/test/test_base.py 2 83.62%
Totals Coverage Status
Change from base Build 12453182960: -0.2%
Covered Lines: 9907
Relevant Lines: 10416

💛 - Coveralls

@onixlas
Copy link
Contributor Author

onixlas commented Dec 24, 2024

It looks like the deprecated fit_predict_score method is being overridden in the DevNet class. Perhaps it should be removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants