Add support for sdk21, updated some versions #1253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle.properties
# Conflicts: # gradle.properties
|
Looks like minification in release build breaks audio download, no idea how to fix it, prob will need some rule for ProGuard, mut without minification works fine |
|
Why are we trying to support android 5.0 here (almost 10 years old) - sorry but I don't think implementing this makes sense. This is not a legacy app. |
|
Why not if compose is capable of? The only thing that's holding it is some
sort of converting Chinese character set and that's it. If this can be
simply disabled for outdated versions than it can run.
…On Tue, Apr 30, 2024, 19:40 BabyBenefactor ***@***.***> wrote:
Why are we trying to support android 5.0 here (almost 10 years old) -
sorry but I don't think implementing this makes sense. This is not a legacy
app.
Or am I missing something 😨
—
Reply to this email directly, view it on GitHub
<#1253 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATD6MCCGANPV47OIOBZPXS3Y77CPZAVCNFSM6AAAAABFEGWXZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVHEZTAMBWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request ever, so tell me if I fucked smth up