Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment before assignment #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yrrah
Copy link

@yrrah yrrah commented Nov 11, 2023

Please let me know if this is correct:

The background / unlabeled part of a mask is index 0.

If you have two objects being tracked, they would be index 1 & 2 and
SegTracker.curr_idx = 2

Then when SegTracker.find_new_objs() finds one additional object, it should set the index in the resulting combined mask to SegTracker.curr_idx + 1 = 3

Currently the increment happens after assignment, so the third object incorrectly gets assigned SegTracker.curr_idx = 2

This might be the cause of #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant