Feature: Allow registering custom Twig tests expression #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackad
reviewed
Jan 22, 2025
zackad
reviewed
Jan 22, 2025
zackad
reviewed
Jan 22, 2025
zackad
changed the title
|
@zackad Btw, I will add documentation for the new option, once I'm done with the coding. |
zackad
changed the title
zackad
added
Enhancement
zackad
force-pushed
the
feat/custom-test-expressions
branch
from
17a2556 to
555602f
Compare
|
thanks @aarongerig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new config option
twigTestExpressions, which allows the user to register any custom Twig tests. This makes those custom tests known to the parser without throwing any errors.@zackad I tried to add the functionality with the best of my knowledge on how to integrate something like that in a Prettier plugin, like this one. I hope we can work with that and I'm always very grateful for inputs. Let me know, if I can do something differently to refactor this implementation.