Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cram/async/io/writer: Add convenience method to write file definition and SAM header #294

Closed
zaeleus opened this issue Aug 26, 2024 · 0 comments
Closed

cram/async/io/writer: Add convenience method to write file definition and SAM header #294

zaeleus opened this issue Aug 26, 2024 · 0 comments
Assignees
@zaeleus
Labels
cram enhancement New feature or request

Comments

@zaeleus
Copy link
Owner

zaeleus commented Aug 26, 2024

In addition, I also noticed some slight differences in function naming schemes between SAM/BAM and CRAM. For example, the SAM and BAM async Writers have a write_header function, however, the reciprocal CRAM function is write_file_header - not sure if this was intended though.

Originally posted by @mbhall88 in #292 (comment)

The async CRAM writer is missing the equivalent of cram::io::Writer::write_header.
@zaeleus zaeleus added enhancement New feature or request cram labels Aug 26, 2024
@zaeleus zaeleus self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaeleus zaeleus

Labels
cram enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaeleus