Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cram/io/writer/builder: Rename Builder::build_with_writer to Builder::build_from_writer #295

Closed
zaeleus opened this issue Aug 26, 2024 · 0 comments
Closed

cram/io/writer/builder: Rename Builder::build_with_writer to Builder::build_from_writer #295

zaeleus opened this issue Aug 26, 2024 · 0 comments
Assignees
@zaeleus
Labels
cram

Comments

@zaeleus
Copy link
Owner

zaeleus commented Aug 26, 2024

Also, the CRAM async builder has the function build_with_writer rather than the build_from_writer. I appreciate these are minor things, but thought I would raise them in case you want to move this library towards consistent names across modules/crates. I guess for backwards compatibility we could add the #[deprecated attribute if you want to introduce the consistent named version.

Originally posted by @mbhall88 in #292 (comment)

Builders in noodles use the from preposition instead of with.
@zaeleus zaeleus added the cram label Aug 26, 2024
@zaeleus zaeleus self-assigned this Aug 26, 2024
zaeleus added a commit that referenced this issue Aug 28, 2024
@zaeleus
cram/io/writer/builder: Rename Builder::build_with_path to Builder::b…
8b2cd79 
…uild_from_path

See #295.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaeleus zaeleus

Labels
cram
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaeleus