Merged
Conversation
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for passing a model via the top-level GlmOcr(..., model=...) constructor when running in self-hosted mode, ensuring it reaches the self-hosted OCR API config.
Changes:
- Forward
modelconstructor override topipeline.ocr_api.model(in addition topipeline.maas.model). - Add a unit test asserting
GlmOcr(mode="selfhosted", model=...)propagates toconfig_model.pipeline.ocr_api.model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
glmocr/config.py |
Updates GlmOcrConfig.from_env() to apply model override to both MaaS and self-hosted OCR API config paths. |
glmocr/tests/test_unit.py |
Adds a unit test covering model forwarding behavior for self-hosted mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #159
Contribution Guide
We welcome your contributions to this repository. To ensure elegant code style and better code quality, we have prepared
the following contribution guidelines.
What We Accept
follows the coding standards below.
your code strictly follows the coding standards below.
Code Style Guide
Good code style is an art. We have prepared a
pre-commithook to enforce consistent codeformatting across the project. You can clean up your code following the steps below:
If your code complies with the standards, you should not see any errors.
Naming Conventions
a,b,c.