Allow serializing &T as Bincoded<T> #13
clippy
8 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 8 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa1 2023-08-23)
Annotations
Check failure on line 455 in proc/src/serialize.rs
github-actions / clippy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> proc/src/serialize.rs:455:36
|
455 | generics.params.extend(cfg.generics.params.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `cfg.generics.params`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 346 in proc/src/serialize.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> proc/src/serialize.rs:346:41
|
346 | enum_field_order_checks(&data, &input.ident, &cfg.formula)
| ^^^^^ help: change this to: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 243 in proc/src/serialize.rs
github-actions / clippy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> proc/src/serialize.rs:243:36
|
243 | generics.params.extend(cfg.generics.params.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `cfg.generics.params`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 149 in proc/src/serialize.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> proc/src/serialize.rs:149:43
|
149 | struct_field_order_checks(&data, cfg.variant.as_ref(), &input.ident, &cfg.formula)
| ^^^^^ help: change this to: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 348 in proc/src/deserialize.rs
github-actions / clippy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> proc/src/deserialize.rs:348:25
|
348 | .extend(cfg.generics.params.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `cfg.generics.params`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 333 in proc/src/deserialize.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> proc/src/deserialize.rs:333:41
|
333 | enum_field_order_checks(&data, &input.ident, &cfg.formula)
| ^^^^^ help: change this to: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 190 in proc/src/deserialize.rs
github-actions / clippy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> proc/src/deserialize.rs:190:25
|
190 | .extend(cfg.generics.params.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `cfg.generics.params`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
Check failure on line 175 in proc/src/deserialize.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> proc/src/deserialize.rs:175:43
|
175 | struct_field_order_checks(&data, None, &input.ident, &cfg.formula)
| ^^^^^ help: change this to: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`