Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing newer C++ Version #2

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Fixing newer C++ Version #2

wants to merge 22 commits into from

Conversation

datvo06
Copy link
Contributor

@datvo06 datvo06 commented Aug 3, 2024

I have made the following changes:
(1) Simplifying the template arguments (e.g., ALLOC is removed for classes in which the default std::alloc can be used)
(2) For conv_hash_type in element_parser, this was coupled with other hashmaps (e.g., level_one_hmap), once we update /release the original edges, the key also got removed. I updated this by copying the key in case of std::string.
(3) Update the code to use total_max_pattern while mining for random_max_graph instead of "120,400" in graph_test
(4) I also added CMake and some C++ 17 features. Project can now be build with

cd test && mkdir build && cd build
cmake ..
make

Thanks for reviewing my changes.
Dat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant