-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing newer C++ Version #2
Open
datvo06
wants to merge
22
commits into
zakimjz:master
Choose a base branch
from
datvo06:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also fixed the copying of conv hash type to decouple the hashmap key and the actual object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following changes:
(1) Simplifying the template arguments (e.g., ALLOC is removed for classes in which the default std::alloc can be used)
(2) For conv_hash_type in element_parser, this was coupled with other hashmaps (e.g., level_one_hmap), once we update /release the original edges, the key also got removed. I updated this by copying the key in case of std::string.
(3) Update the code to use total_max_pattern while mining for random_max_graph instead of "120,400" in graph_test
(4) I also added CMake and some C++ 17 features. Project can now be build with
Thanks for reviewing my changes.
Dat