Add support for internel node subnets #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
added
the
minor
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for finding subnets tagged with
kubernetes.io/role/internal-nodeand expose them a.Values.internal_node_subnetsin templates.The purpose of this is to be able to discover and launch a subnet of node pools in internal subnets. This is useful for special instances running with NAT gateways or simply for running nodes in internal subnets.
A concrete use case is getting p5.48xlarge instances working with EFA. Those can't automatically get a public IP so we need another way to give them internet access e.g. via NAT.