-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #552 from zalando-incubator/hostname-rps-collector
Add hostname RPS metric collector
- Loading branch information
Showing
6 changed files
with
569 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| package collector | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "regexp" | ||
| "strconv" | ||
| "strings" | ||
| "time" | ||
|
|
||
| autoscalingv2 "k8s.io/api/autoscaling/v2" | ||
| ) | ||
|
|
||
| const ( | ||
| ExternalRPSMetricType = "requests-per-second" | ||
| ExternalRPSQuery = `scalar(sum(rate(%s{host=~"%s"}[1m])) * %.4f)` | ||
| ) | ||
|
|
||
| type ExternalRPSCollectorPlugin struct { | ||
| metricName string | ||
| promPlugin CollectorPlugin | ||
| pattern *regexp.Regexp | ||
| } | ||
|
|
||
| type ExternalRPSCollector struct { | ||
| interval time.Duration | ||
| promCollector Collector | ||
| } | ||
|
|
||
| func NewExternalRPSCollectorPlugin( | ||
| promPlugin CollectorPlugin, | ||
| metricName string, | ||
| ) (*ExternalRPSCollectorPlugin, error) { | ||
| if metricName == "" { | ||
| return nil, fmt.Errorf("failed to initialize hostname collector plugin, metric name was not defined") | ||
| } | ||
|
|
||
| p, err := regexp.Compile("^[a-zA-Z0-9.-]+$") | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create regular expression to match hostname format") | ||
| } | ||
|
|
||
| return &ExternalRPSCollectorPlugin{ | ||
| metricName: metricName, | ||
| promPlugin: promPlugin, | ||
| pattern: p, | ||
| }, nil | ||
| } | ||
|
|
||
| // NewCollector initializes a new skipper collector from the specified HPA. | ||
| func (p *ExternalRPSCollectorPlugin) NewCollector( | ||
| hpa *autoscalingv2.HorizontalPodAutoscaler, | ||
| config *MetricConfig, | ||
| interval time.Duration, | ||
| ) (Collector, error) { | ||
| if config == nil { | ||
| return nil, fmt.Errorf("metric config not present, it is not possible to initialize the collector") | ||
| } | ||
| // Need to copy config and add a promQL query in order to get | ||
| // RPS data from a specific hostname from prometheus. The idea | ||
| // of the copy is to not modify the original config struct. | ||
| confCopy := *config | ||
|
|
||
| if _, ok := config.Config["hostnames"]; !ok { | ||
| return nil, fmt.Errorf("Hostname is not specified, unable to create collector") | ||
| } | ||
|
|
||
| hostnames := strings.Split(config.Config["hostnames"], ",") | ||
| if p.pattern == nil { | ||
| return nil, fmt.Errorf("plugin did not specify hostname regex pattern, unable to create collector") | ||
| } | ||
| for _, h := range hostnames { | ||
| if ok := p.pattern.MatchString(h); !ok { | ||
| return nil, fmt.Errorf( | ||
| "invalid hostname format, unable to create collector: %s", | ||
| h, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| weight := 1.0 | ||
| if w, ok := config.Config["weight"]; ok { | ||
| num, err := strconv.ParseFloat(w, 64) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not parse weight annotation, unable to create collector: %s", w) | ||
| } | ||
| weight = num / 100.0 | ||
| } | ||
|
|
||
|
|
||
|
|
||
| confCopy.Config = map[string]string{ | ||
| "query": fmt.Sprintf( | ||
| ExternalRPSQuery, | ||
| p.metricName, | ||
| strings.ReplaceAll(strings.Join(hostnames, "|"), ".", "_"), | ||
| weight, | ||
| ), | ||
| } | ||
|
|
||
| c, err := p.promPlugin.NewCollector(hpa, &confCopy, interval) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &ExternalRPSCollector{ | ||
| interval: interval, | ||
| promCollector: c, | ||
| }, nil | ||
| } | ||
|
|
||
| // GetMetrics gets hostname metrics from Prometheus | ||
| func (c *ExternalRPSCollector) GetMetrics() ([]CollectedMetric, error) { | ||
| v, err := c.promCollector.GetMetrics() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if len(v) != 1 { | ||
| return nil, fmt.Errorf("expected to only get one metric value, got %d", len(v)) | ||
| } | ||
| return v, nil | ||
| } | ||
|
|
||
| // Interval returns the interval at which the collector should run. | ||
| func (c *ExternalRPSCollector) Interval() time.Duration { | ||
| return c.interval | ||
| } | ||
|
|
Oops, something went wrong.