Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kubernetes helm chart #238

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Conversation

tanersener
Copy link
Contributor

@tanersener tanersener commented Dec 19, 2020

Adds a kubernetes helm chart

Issue : #56

Description

Creates a helm chart for this project that can be installed using helm install.

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Refactor/improvements

Features

  • Existing helm deployment files are preserved
  • Helm chart is added under the docs/helm folder
    • Service account definition in rbac.yaml file is extracted as a separate service-account.yaml file
    • Missing kube-metrics-adapter-resource-reader cluster role binding is added
    • Definition names are updated with kube-metrics-adapter prefix
  • Can be installed using helm install
  • All docker image options except --help and --bind-address can be customized during helm install
  • Allows changing the namespace
  • Can be used to install a different docker image

Deployment Notes

You can deploy the chart using the following command

helm install kube-metrics-adapter helm --set prometheus.server=http://iamserver --set aws.region=eu-west1 --set prometheus.metricsAddress=:9090 --set zmon.tokenName=QTCuP5lwSQj6hdUrnGqAcYyspGY17U --set influxDB.address=http://influx --set log.level=2

@mikkeloscar
Copy link
Contributor

@tanersener Thanks for this! As we don't use helm ourselves we can support this as best effort, but I would prefer if we also keep the existing non-helm resources in place. Could you change the PR to have both helm and non-helm manifests?

@tanersener
Copy link
Contributor Author

@mikkeloscar Moved the helm folder under the docs. Now we have both manifests side by side.

@tanersener tanersener changed the title Reorganize helm deployment files as a helm chart Add a kubernetes helm chart Jan 4, 2021
@mikkeloscar
Copy link
Contributor

👍

1 similar comment
@jonathanbeber
Copy link
Contributor

👍

@mikkeloscar mikkeloscar merged commit 2531ddc into zalando-incubator:master Jan 4, 2021
@tanersener
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants