Skip to content

skipper-validation-webhook: enabled missing configuration for custom filters #10165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szuecs merged 1 commit into from
Dec 4, 2025
Merged

skipper-validation-webhook: enabled missing configuration for custom filters #10165

szuecs merged 1 commit into from
Dec 4, 2025
+184 −6

Conversation

@vlktna
Copy link
Member

@vlktna vlktna commented Nov 6, 2025

  • OAuth2 Tokeninfo Filters
  • OAuth2 Grant Flow
  • Open Policy Agent
  • Rate Limiter
  • Compression

@vlktna vlktna added architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services. do-not-merge labels Nov 6, 2025
@vlktna vlktna force-pushed the enabled-missing-configuration-for-custom-filters branch 2 times, most recently from 091abf4 to a4a251f Compare November 7, 2025 10:56
@MustafaSaber MustafaSaber changed the title enabled missing configuration for custom filters skipper-validation-webhook: enabled missing configuration for custom filters Nov 7, 2025
szuecs
szuecs reviewed Nov 7, 2025
View reviewed changes
@zalando-robot
Copy link

zalando-robot commented Nov 10, 2025

Deployment Checklist

This change falls under the deployment policy.

💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:

  • Detailed release notes are provided in this PR’s description.
  • Thorough load-testing has been performed, and is documented in the description/comment.
  • Technical review: Principal Engineers or Tech Leads have green-lit your changes, and the reviewer is named in the description/comments.
  • You can enable/disable the change via feature toggles, and have confirmed these toggles work as expected.
  • Application Owner (Director+) approval is given about the PR, and the approver is named in the description/comments.

👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked.
Reports about deployment policy adherence will be circulated daily for Cyber-Week-relevant applications.

@MustafaSaber MustafaSaber mentioned this pull request Nov 13, 2025
Closed
@vlktna vlktna force-pushed the enabled-missing-configuration-for-custom-filters branch from 38a2c0c to a663566 Compare November 14, 2025 14:57
@vlktna
Copy link
Member Author

vlktna commented Nov 14, 2025

TODO: add - "-source-poll-timeout=9223372036854775807" # Disable loading routing table in dataclient

@vlktna vlktna force-pushed the enabled-missing-configuration-for-custom-filters branch 2 times, most recently from 11be31f to 34e004e Compare November 20, 2025 15:58
@MustafaSaber MustafaSaber force-pushed the enabled-missing-configuration-for-custom-filters branch from da738be to 53bd33c Compare November 24, 2025 17:12
@vlktna vlktna force-pushed the enabled-missing-configuration-for-custom-filters branch from 66dc35e to a39809c Compare December 3, 2025 13:23
@vlktna vlktna force-pushed the enabled-missing-configuration-for-custom-filters branch from a39809c to de6c4b2 Compare December 3, 2025 14:59
@vlktna
Copy link
Member Author

vlktna commented Dec 4, 2025

👍

@vlktna vlktna requested review from MustafaSaber, demonCoder95 and szuecs and removed request for demonCoder95 December 4, 2025 11:22
szuecs
szuecs reviewed Dec 4, 2025
View reviewed changes
cluster/manifests/02-skipper-validation-webhook/deployment.yaml
- "-swarm-redis-read-timeout={{ .Cluster.ConfigItems.skipper_redis_read_timeout }}"
- "-swarm-redis-write-timeout={{ .Cluster.ConfigItems.skipper_redis_write_timeout }}"
- "-cluster-ratelimit-max-group-shards={{ .Cluster.ConfigItems.skipper_cluster_ratelimit_max_group_shards }}"
- "-swarm-redis-min-conns={{ .Cluster.ConfigItems.skipper_redis_min_conns }}"
Copy link
Member

@szuecs szuecs Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also hard code values here. For example connections to "1", because we do not do roundtrips to redis anyways so why should we have the same values as the data plane.
Timeouts could be all "1s" for example, because they do not matter here and don't change the validation.

@szuecs
Copy link
Member

szuecs commented Dec 4, 2025

👍

@szuecs szuecs merged commit afa19e5 into dev Dec 4, 2025
15 checks passed
@szuecs szuecs deleted the enabled-missing-configuration-for-custom-filters branch December 4, 2025 12:21
@szuecs
Copy link
Member

szuecs commented Dec 4, 2025

follow up: #10198

@k8s-on-aws-manager-app k8s-on-aws-manager-app bot mentioned this pull request Dec 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs szuecs left review comments

@MustafaSaber MustafaSaber Awaiting requested review from MustafaSaber

Assignees

No one assigned

Labels

architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vlktna @zalando-robot @szuecs